Use null coalescing operator for cleaner code in fill_blanks and question classes

Author: AngelFQC

main/exercise/fill_blanks.class.php

@@ -1238,13 +1238,13 @@ public static function getHtmlDisplayForAnswer(
                     continue;
                 }
             }
-            $result .= isset($listStudentAnswerInfo['common_words'][$i]) ? $listStudentAnswerInfo['common_words'][$i] : '';
-            $studentLabel = isset($listStudentAnswerInfo['student_answer'][$i]) ? $listStudentAnswerInfo['student_answer'][$i] : '';
+            $result .= $listStudentAnswerInfo['common_words'][$i] ?? '';
+            $studentLabel = $listStudentAnswerInfo['student_answer'][$i] ?? '';
             $result .= $studentLabel;
         }
 
         // the last common word (should be </p>)
-        $result .= isset($listStudentAnswerInfo['common_words'][$i]) ? $listStudentAnswerInfo['common_words'][$i] : '';
+        $result .= $listStudentAnswerInfo['common_words'][$i] ?? '';
 
         return $result;
     }

main/exercise/question.class.php

@@ -2255,7 +2255,7 @@ public function return_header(Exercise $exercise, $counter = null, $score = [])
             case ORAL_EXPRESSION:
             case ANSWER_IN_OFFICE_DOC:
             case ANNOTATION:
-                $score['revised'] = isset($score['revised']) ? $score['revised'] : false;
+                $score['revised'] = $score['revised'] ?? false;
                 if ($score['revised'] == true) {
                     $scoreLabel = get_lang('Revised');
                     $class = '';
@@ -2304,8 +2304,8 @@ public function return_header(Exercise $exercise, $counter = null, $score = [])
         }
 
         $scoreCurrent = [
-            'used' => isset($score['score']) ? $score['score'] : '',
-            'missing' => isset($score['weight']) ? $score['weight'] : '',
+            'used' => $score['score'] ?? '',
+            'missing' => $score['weight'] ?? '',
         ];
 
         // Check whether we need to hide the question ID

main/inc/ajax/exercise.ajax.php

@@ -489,23 +489,22 @@
         }
 
         // "all" or "simple" strings means that there's one or all questions exercise type
-        $type = isset($_REQUEST['type']) ? $_REQUEST['type'] : null;
+        $type = $_REQUEST['type'] ?? null;
 
         // Questions choices.
-        $choice = isset($_REQUEST['choice']) ? $_REQUEST['choice'] : [];
+        $choice = $_REQUEST['choice'] ?? [];
 
         // certainty degree choice
-        $choiceDegreeCertainty = isset($_REQUEST['choiceDegreeCertainty']) ? $_REQUEST['choiceDegreeCertainty'] : [];
+        $choiceDegreeCertainty = $_REQUEST['choiceDegreeCertainty'] ?? [];
 
         // Hot spot coordinates from all questions.
-        $hot_spot_coordinates = isset($_REQUEST['hotspot']) ? $_REQUEST['hotspot'] : [];
+        $hot_spot_coordinates = $_REQUEST['hotspot'] ?? [];
 
         // the filenames in upload answer type
-        $uploadAnswerFileNames = isset($_REQUEST['uploadChoice']) ? $_REQUEST['uploadChoice'] : [];
+        $uploadAnswerFileNames = $_REQUEST['uploadChoice'] ?? [];
 
         // There is a reminder?
-        $remind_list = isset($_REQUEST['remind_list']) && !empty($_REQUEST['remind_list'])
-            ? array_keys($_REQUEST['remind_list']) : [];
+        $remind_list = !empty($_REQUEST['remind_list']) ? array_keys($_REQUEST['remind_list']) : [];
 
         // Needed in manage_answer.
         $learnpath_id = isset($_REQUEST['learnpath_id']) ? (int) $_REQUEST['learnpath_id'] : 0;
@@ -662,7 +661,7 @@
             if ($type === 'simple' && $question_id != $my_question_id) {
                 continue;
             }
-            $my_choice = isset($choice[$my_question_id]) ? $choice[$my_question_id] : null;
+            $my_choice = $choice[$my_question_id] ?? null;
             $objQuestionTmp = Question::read($my_question_id, $objExercise->course);
             $myChoiceDegreeCertainty = null;
             if ($objQuestionTmp->type === MULTIPLE_ANSWER_TRUE_FALSE_DEGREE_CERTAINTY) {
@@ -700,8 +699,7 @@
 
             // This variable came from exercise_submit_modal.php.
             $hotspot_delineation_result = null;
-            if (isset($_SESSION['hotspot_delineation_result']) &&
-                isset($_SESSION['hotspot_delineation_result'][$objExercise->selectId()])
+            if (isset($_SESSION['hotspot_delineation_result'][$objExercise->selectId()])
             ) {
                 $hotspot_delineation_result = $_SESSION['hotspot_delineation_result'][$objExercise->selectId()][$my_question_id];
             }