Catalogue: Fix showing correct registration button for courses - refs #2805 (#6953)

Co-authored-by: Yannick Warnier <ywarnier@users.noreply.github.com>

Author: Ilyassbennanii

assets/vue/components/course/CatalogueCourseCard.vue

@@ -140,15 +140,15 @@
         />
 
         <Button
-          v-else-if="course.subscribe && props.currentUserId"
+          v-else-if="course.subscribe && props.currentUserId && allowSelfSignup"
           :label="$t('Subscribe')"
           icon="pi pi-sign-in"
           class="w-full"
           @click="subscribeToCourse"
         />
 
         <Button
-          v-else-if="course.visibility === 2 && !course.subscribe && props.currentUserId"
+          v-else-if="props.currentUserId && !allowSelfSignup"
           :label="$t('Subscription not allowed')"
           icon="pi pi-ban"
           disabled
@@ -343,4 +343,10 @@ const { isLocked, hasRequirements, requirementList, graphImage, fetchStatus } =
 onMounted(() => {
   fetchStatus()
 })
+
+const allowSelfSignup = computed(() => {
+  if (props.course?.allow_self_signup !== undefined) return Boolean(props.course.allow_self_signup)
+  if (props.course?.allowSelfSignup !== undefined) return Boolean(props.course.allowSelfSignup)
+  return props.course?.visibility === 0
+})
 </script>

src/CoreBundle/Controller/CatalogueController.php

@@ -534,6 +534,12 @@ public function autoSubscribeCourse(int $courseId, SettingsManager $settings): J
             return $this->json(['error' => 'Course or user not found'], 400);
         }
 
+        $isPrivileged = $this->isGranted('ROLE_ADMIN') || $this->isGranted('ROLE_SESSION_ADMIN');
+        if (!$course->getAllowSelfSignup() && !$isPrivileged) {
+            return $this->json(['error' => 'Self sign up not allowed for this course'], 403);
+        }
+
+
         $useAutoSession = 'true' === $settings->getSetting('catalog.course_subscription_in_user_s_session', true);
 
         if ($useAutoSession) {

src/CoreBundle/Entity/Course.php

@@ -377,6 +377,13 @@ class Course extends AbstractResource implements ResourceInterface, ResourceWith
     #[Groups(['course:read'])]
     public bool $subscribed = false;
 
+    #[SerializedName('allowSelfSignup')]
+    #[Groups(['course:read','session:read'])]
+    public function getAllowSelfSignup(): bool
+    {
+        return $this->visibility !== self::REGISTERED;
+    }
+
     public function __construct()
     {
         $this->visibility = self::OPEN_PLATFORM;