Skip to content

Commit a9a8d50

Browse files
committed
Minor - fix sql error
1 parent cd694bd commit a9a8d50

File tree

1 file changed

+27
-23
lines changed

1 file changed

+27
-23
lines changed

main/lp/learnpathItem.class.php

Lines changed: 27 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2613,35 +2613,39 @@ public function parse_prereq($prereqs_string, $items, $refs_list, $user_id)
26132613
session_id = '.$sessionId.'
26142614
LIMIT 0, 1';
26152615
$rs_lp = Database::query($sql);
2616-
$lp_id = Database::fetch_row($rs_lp);
2617-
$my_lp_id = $lp_id[0];
2616+
if (Database::num_rows($rs_lp)) {
2617+
$lp_id = Database::fetch_row($rs_lp);
2618+
$my_lp_id = $lp_id[0];
26182619

2619-
$sql = 'SELECT status FROM '.$lp_item_view.'
2620-
WHERE
2621-
c_id = '.$course_id.' AND
2622-
lp_view_id = '.$my_lp_id.' AND
2623-
lp_item_id = '.$refs_list[$prereqs_string].'
2624-
LIMIT 0, 1';
2625-
$rs_lp = Database::query($sql);
2626-
$status_array = Database::fetch_row($rs_lp);
2627-
$status = $status_array[0];
2620+
$sql = 'SELECT status FROM '.$lp_item_view.'
2621+
WHERE
2622+
c_id = '.$course_id.' AND
2623+
lp_view_id = '.$my_lp_id.' AND
2624+
lp_item_id = '.$refs_list[$prereqs_string].'
2625+
LIMIT 0, 1';
2626+
$rs_lp = Database::query($sql);
2627+
$status_array = Database::fetch_row($rs_lp);
2628+
$status = $status_array[0];
26282629

2629-
$returnstatus = ($status == $this->possible_status[2]) || ($status == $this->possible_status[3]);
2630-
if (!$returnstatus && empty($this->prereq_alert)) {
2631-
$this->prereq_alert = get_lang('LearnpathPrereqNotCompleted');
2632-
}
2633-
if (!$returnstatus) {
2634-
if (self::DEBUG > 1) {
2635-
error_log('New LP - Prerequisite '.$prereqs_string.' not complete');
2630+
$returnstatus = $status == $this->possible_status[2] || $status == $this->possible_status[3];
2631+
if (!$returnstatus && empty($this->prereq_alert)) {
2632+
$this->prereq_alert = get_lang('LearnpathPrereqNotCompleted');
26362633
}
2637-
} else {
2638-
if (self::DEBUG > 1) {
2639-
error_log('New LP - Prerequisite '.$prereqs_string.' complete');
2634+
if (!$returnstatus) {
2635+
if (self::DEBUG > 1) {
2636+
error_log(
2637+
'New LP - Prerequisite '.$prereqs_string.' not complete'
2638+
);
2639+
}
2640+
} else {
2641+
if (self::DEBUG > 1) {
2642+
error_log('New LP - Prerequisite '.$prereqs_string.' complete');
2643+
}
26402644
}
2645+
2646+
return $returnstatus;
26412647
}
26422648
}
2643-
2644-
return $returnstatus;
26452649
}
26462650
} else {
26472651
if (self::DEBUG > 1) {

0 commit comments

Comments
 (0)