Merge pull request #5789 from christianbeeznest/ofaj-21592

Internal: Fix date and time format in datepickers by locale - refs BT#21592

Author: christianbeeznest

public/main/inc/lib/formvalidator/Element/DatePicker.php

@@ -101,13 +101,15 @@ private function getElementJS(): string
         $localeCode = $this->getLocaleCode();
         $id = $this->getAttribute('id');
 
+        $altFormat = ($localeCode === 'en') ? 'F d, Y' : 'd F, Y';
+
         return "<script>
         document.addEventListener('DOMContentLoaded', function () {
             function initializeFlatpickr() {
                 const fp = flatpickr('#{$id}', {
                     locale: '{$localeCode}',
                     altInput: true,
-                    altFormat: '".get_lang('F d, Y')."',
+                    altFormat: '{$altFormat}',
                     enableTime: false,
                     dateFormat: 'Y-m-d',
                     time_24hr: true,

public/main/inc/lib/formvalidator/Element/DateTimePicker.php

@@ -72,13 +72,15 @@ private function getElementJS(): string
         $localeCode = $this->getLocaleCode();
         $id = $this->getAttribute('id');
 
+        $altFormat = ($localeCode === 'en') ? 'F d, Y - H:i' : 'd F, Y - H:i';
+
         $js = "<script>
         document.addEventListener('DOMContentLoaded', function () {
             function initializeFlatpickr() {
                 const fp = flatpickr('#{$id}', {
                     locale: '{$localeCode}',
                     altInput: true,
-                    altFormat: '".get_lang('F d, Y')." ".get_lang('at')." H:i',
+                    altFormat: '{$altFormat}',
                     enableTime: true,
                     dateFormat: 'Y-m-d H:i',
                     time_24hr: true,

src/CoreBundle/DataFixtures/ExtraFieldFixtures.php

@@ -389,6 +389,8 @@ public static function getExtraFields(): array
                 'display_text' => 'GDPR compliance',
                 'item_type' => ExtraField::USER_FIELD_TYPE,
                 'value_type' => ExtraField::FIELD_TYPE_CHECKBOX,
+                'visible_to_self' => true,
+                'changeable' => true,
             ],
             [
                 'variable' => 'isFromNewLogin',