Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send a message to an open ticket if a user leaves the server #156

Open
dlsnyder8 opened this issue Oct 30, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@dlsnyder8
Copy link
Contributor

dlsnyder8 commented Oct 30, 2023

Please describe the feature you'd like
Suggestions 516 & 510

  • add on_member_leave catch
  • check if member has open ticket
  • Sends a message in the ticket saying the user has left the server
  • Adds a button to message to quickly close ticket
  • Invalidates button if user rejoins server before ticket closed
@dlsnyder8 dlsnyder8 added the enhancement New feature or request label Oct 30, 2023
@chamburr
Copy link
Owner

chamburr commented Nov 1, 2023

This feature would mean that there might be messages from users that are not seen by staff...

@dlsnyder8
Copy link
Contributor Author

I can add a toggle for it so that it's opt-in

@chamburr
Copy link
Owner

chamburr commented Nov 1, 2023

I mean, I don't like that there's a chance the intended recipient will never see the message. Users send messages through ModMail knowing that they will get to someone, and the role of ModMail is precisely to deliver the messages. While we don't care what staff do with the messages, some feature that makes those messages disappear is just unfriendly to the users. Ultimately, it's all about a balance between features for users and for staff, and for this one I'm leaning on the users' side.

@dlsnyder8
Copy link
Contributor Author

dlsnyder8 commented Nov 1, 2023

If it was a premium feature, then the messages would not be lost since they would/could have advanced logging enabled. I agree with your point that lost messages aren't a good thing, but this only happens when the user who created the ticket leaves the server. It's a waste of staff time to write a response to a ticket (sometimes lengthy) only to be hit with a "Your message cannot be delivered."

The issue could also be modified to leave a message in the open ticket saying that the user has left the server and further messages can't be delivered. If that were the case I would also want to add an on_member_join trigger for if they decide to return so tickets aren't closed if the user joins back.

@chamburr
Copy link
Owner

chamburr commented Nov 1, 2023

Sending a message in the ticket is great. Could you update this issue?

@dlsnyder8 dlsnyder8 changed the title Auto close ticket when member leaves feat: Send a message to an open ticket if a user leaves the server Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants