escape codes from ansi-escapes not being stripped by strip-ansi?

[derhuerst]

Hey, thanks for this useful tool!

If I understand correctly, the following escape codes should be stripped by strip-ansi, right?

const esc = require('ansi-escapes')
const stripAnsi = require('strip-ansi')

esc.scrollDown // '\u001b[T'
stripAnsi(esc.scrollDown) // '\u001b[T'
esc.beep // '\u0007'
stripAnsi(esc.beep) // '\u0007'

clearScreen gets stripped though:

esc.clearScreen // '\u001bc'
stripAnsi(esc.clearScreen) // ''

[Qix-]

Beep won't. scrollDown should. Let me look :)

[Qix-]

#20 fixes this - good catch :)

[Qix-]

To be clear, beep isn't actually an escape code. It's considered a valid ASCII character that has nothing to do with escapes and the like. It'd be out of scope for this module.

cc @sindresorhus, not sure you opinion on it. It has a property in ansi-escapes but it isn't really an escape.

[derhuerst]

To be clear, beep isn't actually an escape code. It's considered a valid ASCII character that has nothing to do with escapes and the like. It'd be out of scope for this module.

Yeah, makes sense now that I look at it again.

#20 fixes this - good catch :)

Cool!