Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

fix: Include CGridItem in type definitions #502

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

t-buss
Copy link
Contributor

@t-buss t-buss commented Dec 20, 2021

Description

We notices that the type definitions do not include CGridItem, which leads to false error messages in the IDE although everything works when run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021

🦋 Changeset detected

Latest commit: b783840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chakra-ui/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/2vf5nACEFtYgYwKzm9t2DrbdJNGJ
✅ Preview: https://chakra-ui-vue-git-fork-t-buss-patch-1-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b783840:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@t-buss t-buss changed the title Include CGridItem in type definitions Fix: Include CGridItem in type definitions Dec 21, 2021
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @t-buss This is great!

@codebender828 codebender828 self-requested a review December 22, 2021 16:36
codebender828
codebender828 previously approved these changes Dec 22, 2021
@codebender828 codebender828 changed the title Fix: Include CGridItem in type definitions fix: Include CGridItem in type definitions Dec 22, 2021
@codebender828 codebender828 merged commit 473cb94 into chakra-ui:develop Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants