feat(context): improve createContext type definitions#3783
Open
isBatak wants to merge 6 commits intochakra-ui:mainfrom
Open
feat(context): improve createContext type definitions#3783isBatak wants to merge 6 commits intochakra-ui:mainfrom
isBatak wants to merge 6 commits intochakra-ui:mainfrom
Conversation
|
@isBatak is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
… for itemState.id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Fix the return type of
createContextwhenstrictis set tofalseso that the generated hook correctly includesundefinedin its return type.Currently, when using
createContext({ strict: false }), the return type ofuseContext()does not includeundefined, even though thecontextcan beundefinedat runtime.⛳️ Current behavior (updates)
Even though
contextcan beundefined, its type does not includeundefined. As a result, when using it conditionally:ESLint auto-fix removes the optional chaining (?.) because the type system indicates that
contextis always defined.🚀 New behavior
When strict is false, the return type of the generated hook becomes:
This correctly reflects runtime behavior and allows safe conditional usage like:
TypeScript and ESLint will no longer incorrectly treat the value as always defined.
💣 Is this a breaking change (Yes/No):
No.
This change only improves the TypeScript return type to better reflect the existing runtime behavior when strict is false.
📝 Additional Information