Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: SyntaxError message for Merge conflict marker (as detected by TypeScript) #3698

Open
dilijev opened this issue Sep 9, 2017 · 4 comments

Comments

@dilijev
Copy link
Contributor

dilijev commented Sep 9, 2017

Typescript has a great error message. When encountering lines generated by a merge conflict (and left in if unresolved or incorrectly resolved):

error TS1185: Merge conflict marker encountered.

Note: This wouldn't be able to detect markers inside of multiline-strings.

/cc @bterlson

@bterlson
Copy link
Contributor

bterlson commented Sep 9, 2017

Should detect diff3 format as described here as well: microsoft/TypeScript#16129.

@dilijev
Copy link
Contributor Author

dilijev commented Sep 9, 2017

@bterlson Would detecting this potentially cause a spec violation? I'd assume the presence of such tokens would cause a SyntaxError anyway, so we'd just be giving a helpful message. Just want to make sure.

@dilijev dilijev changed the title ParseError for Merge conflict marker (as detected by TypeScript) SyntaxError for Merge conflict marker (as detected by TypeScript) Sep 9, 2017
@dilijev dilijev changed the title SyntaxError for Merge conflict marker (as detected by TypeScript) Request: SyntaxError message for Merge conflict marker (as detected by TypeScript) Sep 9, 2017
@dilijev
Copy link
Contributor Author

dilijev commented Sep 9, 2017

Note: This wouldn't be able to detect markers inside of multiline-strings.

@bterlson
Copy link
Contributor

bterlson commented Sep 9, 2017

@dilijev no spec violation, still a syntax error just with a nicer message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants