chore(api): rename integration.Kind with integration.ExtensionID (#150)

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Author: migmartri

app/cli/cmd/integration_add.go

@@ -23,10 +23,9 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var integrationDescription string
-
 func newConfigIntegrationAddCmd() *cobra.Command {
 	var options []string
+	var integrationDescription string
 
 	cmd := &cobra.Command{
 		Use:     "add INTEGRATION_ID --options key=value,key=value",

app/cli/cmd/integration_add_deptrack.go

@@ -25,7 +25,7 @@ import (
 )
 
 func newIntegrationAddDepTrackCmd() *cobra.Command {
-	var instance string
+	var instance, integrationDescription string
 	var allowAutoCreate bool
 
 	cmd := &cobra.Command{

app/cli/internal/action/integration_add.go

@@ -31,7 +31,7 @@ func NewIntegrationAdd(cfg *ActionsOpts) *IntegrationAdd {
 	return &IntegrationAdd{cfg}
 }
 
-func (action *IntegrationAdd) Run(kind, description string, options map[string]any) (*IntegrationItem, error) {
+func (action *IntegrationAdd) Run(extensionID, description string, options map[string]any) (*IntegrationItem, error) {
 	client := pb.NewIntegrationsServiceClient(action.cfg.CPConnection)
 
 	// Transform to structpb for transport
@@ -41,7 +41,7 @@ func (action *IntegrationAdd) Run(kind, description string, options map[string]a
 	}
 
 	i, err := client.Register(context.Background(), &pb.IntegrationsServiceRegisterRequest{
-		Kind:        kind,
+		ExtensionId: extensionID,
 		Config:      requestConfig,
 		DisplayName: description,
 	})

app/controlplane/api/controlplane/v1/integrations.pb.go

@@ -46,8 +46,8 @@ service IntegrationsService {
 
 message IntegrationsServiceRegisterRequest {
 	// Kind of integration to register
-	// This should match the ID of an existing integration
-	string kind = 1 [(validate.rules).string.min_len = 1];
+	// This should match the ID of an existing extension
+	string extension_id = 1 [(validate.rules).string.min_len = 1];
 	// Arbitrary configuration for the integration
 	google.protobuf.Struct config = 3 [(validate.rules).message.required = true];
 	// Description of the registration, used for display purposes
@@ -59,7 +59,9 @@ message IntegrationsServiceRegisterResponse {
 }
 
 message IntegrationsServiceAttachRequest{
+	// UUID of the workflow to attach
 	string workflow_id = 1 [(validate.rules).string.uuid = true];
+	// UUID of the integration registration to attach
 	string integration_id = 2 [(validate.rules).string.uuid = true];
 	// Arbitrary configuration for the integration
 	google.protobuf.Struct config = 4 [(validate.rules).message.required = true];

app/controlplane/api/controlplane/v1/integrations.pb.validate.go

@@ -76,7 +76,7 @@ func (s *IntegrationsService) Register(ctx context.Context, req *pb.Integrations
 	}
 
 	// lookup the integration
-	integration, err := s.integrations.FindByID(req.Kind)
+	integration, err := s.integrations.FindByID(req.ExtensionId)
 	if err != nil {
 		return nil, errors.NotFound("not found", err.Error())
 	}