feat(cli): reorganize attached integrations (#166)

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Author: migmartri

app/cli/cmd/workflow_integration.go app/cli/cmd/attached_integration.goapp/cli/cmd/workflow_integration.go renamed to app/cli/cmd/attached_integration.go

@@ -19,12 +19,12 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func newWorkflowIntegrationCmd() *cobra.Command {
+func newAttachedIntegrationCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "integration",
-		Short: "Third party integrations",
+		Use:   "attached",
+		Short: "Integrations attached to workflows",
 	}
 
-	cmd.AddCommand(newWorkflowIntegrationAttachCmd(), newWorkflowIntegrationDetachCmd(), newWorkflowIntegrationListCmd())
+	cmd.AddCommand(newAttachedIntegrationAttachCmd(), newAttachedIntegrationDeleteCmd(), newAttachedIntegrationListCmd())
 	return cmd
 }

…p/cli/cmd/workflow_integration_attach.go app/cli/cmd/attached_integration_add.goapp/cli/cmd/workflow_integration_attach.go renamed to app/cli/cmd/attached_integration_add.go app/cli/cmd/workflow_integration_attach.go renamed to app/cli/cmd/attached_integration_add.go

@@ -20,14 +20,15 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func newWorkflowIntegrationAttachCmd() *cobra.Command {
+func newAttachedIntegrationAttachCmd() *cobra.Command {
 	var options []string
 	var integrationID, workflowID string
 
 	cmd := &cobra.Command{
-		Use:     "attach",
+		Use:     "add",
+		Aliases: []string{"attach"},
 		Short:   "Attach an existing registered integration to a workflow",
-		Example: `  chainloop workflow integration attach --workflow deadbeef --integration beefdoingwell --options projectName=MyProject`,
+		Example: `  chainloop integration attached add --workflow deadbeef --integration beefdoingwell --options projectName=MyProject`,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			// Find the integration to extract the kind of integration we care about
 			integration, err := action.NewRegisteredIntegrationDescribe(actionOpts).Run(integrationID)
@@ -51,12 +52,12 @@ func newWorkflowIntegrationAttachCmd() *cobra.Command {
 				return err
 			}
 
-			res, err := action.NewWorkflowIntegrationAttach(actionOpts).Run(integrationID, workflowID, opts)
+			res, err := action.NewAttachedIntegrationAdd(actionOpts).Run(integrationID, workflowID, opts)
 			if err != nil {
 				return err
 			}
 
-			return encodeOutput([]*action.IntegrationAttachmentItem{res}, integrationAttachmentListTableOutput)
+			return encodeOutput([]*action.AttachedIntegrationItem{res}, attachedIntegrationListTableOutput)
 		},
 	}
 
@@ -67,7 +68,6 @@ func newWorkflowIntegrationAttachCmd() *cobra.Command {
 	cobra.CheckErr(cmd.MarkFlagRequired("workflow"))
 
 	cmd.Flags().StringSliceVar(&options, "options", nil, "integration attachment arguments")
-	cmd.AddCommand(newWorkflowIntegrationAttachDependencyTrackCmd())
 
 	return cmd
 }

…p/cli/cmd/workflow_integration_detach.go …p/cli/cmd/attached_integration_delete.goapp/cli/cmd/workflow_integration_detach.go renamed to app/cli/cmd/attached_integration_delete.go app/cli/cmd/workflow_integration_detach.go renamed to app/cli/cmd/attached_integration_delete.go

@@ -20,14 +20,15 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func newWorkflowIntegrationDetachCmd() *cobra.Command {
+func newAttachedIntegrationDeleteCmd() *cobra.Command {
 	var attachmentID string
 
 	cmd := &cobra.Command{
-		Use:   "detach",
-		Short: "Remove a third-party integration attached to a workflow",
+		Use:     "delete",
+		Aliases: []string{"detach"},
+		Short:   "Detach an integration that's attached to a workflow",
 		RunE: func(cmd *cobra.Command, args []string) error {
-			if err := action.NewWorkflowIntegrationDetach(actionOpts).Run(attachmentID); err != nil {
+			if err := action.NewAttachedIntegrationDelete(actionOpts).Run(attachmentID); err != nil {
 				return err
 			}
 

app/cli/cmd/workflow_integration_list.go app/cli/cmd/attached_integration_list.goapp/cli/cmd/workflow_integration_list.go renamed to app/cli/cmd/attached_integration_list.go

@@ -26,30 +26,31 @@ import (
 	"golang.org/x/exp/maps"
 )
 
-func newWorkflowIntegrationListCmd() *cobra.Command {
+func newAttachedIntegrationListCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:     "list",
 		Aliases: []string{"ls"},
 		Short:   "List integrations attached to workflows",
 		RunE: func(cmd *cobra.Command, args []string) error {
-			res, err := action.NewWorkflowIntegrationList(actionOpts).Run()
+			res, err := action.NewAttachedIntegrationList(actionOpts).Run()
 			if err != nil {
 				return err
 			}
 
-			return encodeOutput(res, integrationAttachmentListTableOutput)
+			return encodeOutput(res, attachedIntegrationListTableOutput)
 		},
 	}
 
 	return cmd
 }
 
-func integrationAttachmentListTableOutput(attachments []*action.IntegrationAttachmentItem) error {
+func attachedIntegrationListTableOutput(attachments []*action.AttachedIntegrationItem) error {
 	if len(attachments) == 0 {
 		fmt.Println("there are no integration attached")
 		return nil
 	}
 
+	fmt.Println("Integrations attached to workflows")
 	t := newTableWriter()
 	t.AppendHeader(table.Row{"ID", "Kind", "Config", "Attached At", "Workflow"})
 	for _, i := range attachments {

app/cli/cmd/available_integration_list.go

@@ -47,6 +47,8 @@ func availableIntegrationListTableOutput(items []*action.AvailableIntegrationIte
 		return nil
 	}
 
+	fmt.Println("Available integrations ready to be used during registration")
+
 	t := newTableWriter()
 	t.AppendHeader(table.Row{"ID", "Version", "Description"})
 	for _, i := range items {

app/cli/cmd/integration.go

@@ -25,6 +25,6 @@ func newIntegrationCmd() *cobra.Command {
 		Short: "Third party integrations",
 	}
 
-	cmd.AddCommand(newRegisteredIntegrationCmd(), newAvailableIntegrationCmd())
+	cmd.AddCommand(newRegisteredIntegrationCmd(), newAvailableIntegrationCmd(), newAttachedIntegrationCmd())
 	return cmd
 }

app/cli/cmd/output.go

@@ -41,7 +41,7 @@ type tabulatedData interface {
 		*action.ConfigContextItem |
 		[]*action.RegisteredIntegrationItem |
 		[]*action.AvailableIntegrationItem |
-		[]*action.IntegrationAttachmentItem |
+		[]*action.AttachedIntegrationItem |
 		[]*action.MembershipItem
 }
 

app/cli/cmd/registered_integration_add.go

@@ -68,10 +68,6 @@ func newRegisteredIntegrationAddCmd() *cobra.Command {
 	cmd.Flags().StringVar(&integrationDescription, "description", "", "integration registration description")
 	cmd.Flags().StringSliceVar(&options, "options", nil, "integration arguments")
 
-	// We maintain the dependencytrack integration as a separate command for now
-	// for compatibility reasons
-	cmd.AddCommand(newRegisteredIntegrationAddDepTrackCmd())
-
 	return cmd
 }
 

app/cli/cmd/registered_integration_add_deptrack.go

@@ -49,6 +49,7 @@ func registeredIntegrationListTableOutput(items []*action.RegisteredIntegrationI
 		return nil
 	}
 
+	fmt.Println("Integrations registered and configured in your organization")
 	t := newTableWriter()
 	t.AppendHeader(table.Row{"ID", "Description", "Kind", "Config", "Created At"})
 	for _, i := range items {