fix: support some virtual contexts in toThrow
#1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
commented
Feb 26, 2024
6 tasks
keithamus
reviewed
Feb 26, 2024
This adds support for VM situations where we pass a `RegExp` from another process. Note that we don't have a full fix for this stuff until `check-error` also supports `Error` being from another origin.
Adds support for throwing things like `undefined`, functions, etc.
|
@koddsson could you re-review this? i updated slightly to support throwing of anything (so even and i wrapped |
koddsson
previously approved these changes
May 8, 2024
This was referenced Sep 17, 2024
This was referenced Sep 23, 2024
koddsson
pushed a commit
to koddsson/chai
that referenced
this pull request
Oct 6, 2024
* fix: support some virtual contexts in `toThrow` This adds support for VM situations where we pass a `RegExp` from another process. Note that we don't have a full fix for this stuff until `check-error` also supports `Error` being from another origin. * fix: support throwing of unusual errors Adds support for throwing things like `undefined`, functions, etc. * chore: upgrade check-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for VM situations where we pass a
RegExpfrom another process.Note that we don't have a full fix for this stuff until
check-erroralso supportsErrorbeing from another origin.There's also a tiny fix in here for supporting
throw ''. I have left a PR comment by the relevant line of code