-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chai.version field is incorrect #1525
Comments
Same goes for the Line 22 in ad82f62
|
PRs welcome 😄 |
@keithamus How is it meant to work? Normally when it’s needed I read it from the package.json rather than hard code it, would that work? |
We need to support browser environments which cannot read from the disk. Frankly I think we can just drop it from v5 as it serves little value. |
Hi @keithamus! Is this issue still open to PR's? |
Yes, please go right ahead. |
Great. Would you mind clarifying the expected change? Just to update to '4.3.7'? Or drop given the previous comment. |
We've removed chai version in #1550. |
The runtime Chai version is set to '4.3.3', though the current version is 4.3.7.
Please see https://github.com/chaijs/chai/blob/4.x.x/chai.js#L17C18-L17C18
It seems it should be updated with every release.
The text was updated successfully, but these errors were encountered: