-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x.x] choose a test harness setup #1504
Comments
My vote is for us to move to |
i agree and yes, if we intend on keeping the bundle even once we move to typescript, we'd have two test runs. its possible one day you could drop the bundle entirely, but it does mean the consumer would have to handle the bare specifiers (via a bundler or import maps). |
I won't say never 😉 but that does indeed seem unlikely for the foreseeable. By which I mean to say it won't harm us to invest in ensuring the bundled version is robust while import map usage is very low. |
Just to add to this discussion, Karma is now officially deprecated making option number two less appealing. |
We moved to Web Test Runner in #1546! |
Once we move away from just shipping a bundle, we need something capable of resolving bare specifiers in tests.
karma by itself can't do that, so we would have a few options:
Option 1
Continue shipping a bundle.
If we do this, we can use karma still and consumers can use our bundle in a browser without themselves needing to deal with bare specifiers.
Option 2
Use something like karma-esm.
In theory, karma would then understand the bare specifiers and could run tests against the source rather than a bundle.
Consumers would need their own solution to the same problem (usually a bundler, or an import map).
Option 3
Move to another test runner like web-test-runner or, once they have a browser runner, vitest.
Importantly, whatever test runner we choose should not use jsdom. it should launch a real browser.
Consumers would need their own solution to bare specifiers, just like in option 2.
The text was updated successfully, but these errors were encountered: