Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add semantic-release #248

Merged
merged 1 commit into from
May 28, 2019
Merged

ci: add semantic-release #248

merged 1 commit into from
May 28, 2019

Conversation

austince
Copy link
Contributor

@austince austince commented May 19, 2019

Integrates semantic-release so we don't have to make chore commits or bog Keith down with releasing 🎈

Flow:

  • only releases on master
  • analyzes the commits to determine the type of release (Major, Minor, Patch, no release)
  • creates a git tag
  • creates an npm release
  • creates a github release
  • generates a changelog from commits

If you'd like to test it locally, run npm run release -- --branch build/semantic-release --dry-run

Also:

P.S. the massive diff is mostly the package lock - no fear!

Closes #91
Closes #92

@austince austince force-pushed the build/semantic-release branch from c6dee95 to 2cfe53e Compare May 21, 2019 15:23
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Of course we'll only know if it works by taking it for a spin.

@austince
Copy link
Contributor Author

@keithamus 😅 that's the only unfortunate part - I merged this locally, did a dry-run, and no release was made as expected. Should we wait for someone else to take a look at this as well?

@keithamus
Copy link
Member

Sounds like a good plan. @meeber @lucasfcosta?

Copy link
Member

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! That sounds like a plan. Let's get this in and see if it works.

Copy link
Member

@vieiralucas vieiralucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM too.
I would merge this but I'm afraid that if it for some reason it doesn't works I'll not be sure how to fix it.

@austince
Copy link
Contributor Author

I'll be available tomorrow if we want to merge it then!

@austince austince merged commit da01dba into master May 28, 2019
@austince austince deleted the build/semantic-release branch May 28, 2019 13:31
@austince
Copy link
Contributor Author

austince commented May 28, 2019

@keithamus @lucasfcosta @vieiralucas looks like the GitHub token that's in the CI doesn't have proper permissions to push tags. Who's token should we update it with? The secure NPM token from .travis.yml might also be getting overwritten by the Travis repository settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'npm run posttest' fails when COVERALLS_REPO_TOKEN is unset
4 participants