-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add semantic-release #248
Conversation
bdb1f17
to
c6dee95
Compare
c6dee95
to
2cfe53e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Of course we'll only know if it works by taking it for a spin.
@keithamus 😅 that's the only unfortunate part - I merged this locally, did a dry-run, and no release was made as expected. Should we wait for someone else to take a look at this as well? |
Sounds like a good plan. @meeber @lucasfcosta? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too! That sounds like a plan. Let's get this in and see if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM too.
I would merge this but I'm afraid that if it for some reason it doesn't works I'll not be sure how to fix it.
I'll be available tomorrow if we want to merge it then! |
@keithamus @lucasfcosta @vieiralucas looks like the GitHub token that's in the CI doesn't have proper permissions to push tags. Who's token should we update it with? The secure NPM token from |
Integrates semantic-release so we don't have to make chore commits or bog Keith down with releasing 🎈
Flow:
master
If you'd like to test it locally, run
npm run release -- --branch build/semantic-release --dry-run
Also:
P.S. the massive diff is mostly the package lock - no fear!
Closes #91
Closes #92