Test Constraint::more_complex_custom_constraint_function fails on s390x arch

[souryogurt]

I trying to build and test Cgreen on alternative architectures supported in Fedora,
It seams the test for more_complex_custom_constraint_function fails on s390x architecture.
Test:

cgreen/tests/custom_constraint_messages_tests.c

Lines 129 to 133 in c0ec1e7

	Ensure(CustomConstraint, more_complex_custom_constraint_function) {
	Box box1 = {.id = 1, .size = 5};
	Piece piece99 = {.id = 99, .size = 6};
	assert_that(&piece99, can_fit_in_box(&box1));
	}

Steps to reproduce

Actually I building using koji service that has s390x environment, so not sure how to reproduce it on x86 arch :/

Actual result

Comparing output of custom_constraint_messages_tests to expected: 
*** custom_constraint_messages_tests.output.normalized	Mon May 11 19:16:28 2020
--- /builddir/build/BUILD/cgreen-1.2.0/tests/custom_constraint_messages_tests.expected	Thu Aug  8 19:49:09 2019
***************
*** 7,13 ****
  
  custom_constraint_messages_tests.c: Failure: CustomConstraint -> more_complex_custom_constraint_function 
  	Expected [&piece99] to [fit in box] [&box1]
! 		at offset:			[3]
  			actual value:		[0x63]
  			expected value:		[0x01]
  
--- 7,13 ----
  
  custom_constraint_messages_tests.c: Failure: CustomConstraint -> more_complex_custom_constraint_function 
  	Expected [&piece99] to [fit in box] [&box1]
! 		at offset:			[0]
  			actual value:		[0x63]
  			expected value:		[0x01]

[souryogurt]

I'm not sure but seams its related to big-endianness of s390x and #226

[thoni56]

Yes. This is the same cause, you can see the difference in offset. I just added a more detailed description of the problem in #226.

But it points out that the tests, as they are now, don't work on big-endians. Cgreen works correctly it seems, but the tests of the text reporter output can't factor in the endian-ness.

[souryogurt]

Just checked @alvinchchen patch. I am confirming that the issue is fixed. So the issue can be closed.

Build with 9768d33 and #241 patches succeseed on all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=55602746