This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Add offsettTop to offsetHeight for scrollHeader #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have multiple fixed headers, it’s not enough to calculate the headerHeight as the height of the sticky header element. We need to add the offsetTop to compensate for the first sticky header.
cferdinandi
pushed a commit
that referenced
this pull request
Feb 19, 2014
Add `offsettTop` to `offsetHeigh`t for `scrollHeader`. Allows for multiple fixed headers, or a fixed header that sits slightly below the top of the page.
|
Nice add. Thanks! |
|
Sweet, glad to be of help. Can now switch our bower config to point back to this repo instead of my own branch. |
|
The offset header doesn't seem to work for me. It just stops the scroller working at all. What's the correct usage for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple fixed headers, it’s not enough to calculate the headerHeight as the height of the sticky header element. We need to add the offsetTop to compensate for the first sticky header.
If this is a general behavior that should be included in the smooth-scroll lib I'm not sure - sending this PR as a suggestion to a scenario you might have to consider. That beeing said, it shouldn't be a problem, as the offsetTop will be 0 for users/sites with a singly sticky header.