Merge pull request #14 from itsPG/use-scrollHeight

Chris Ferdinandi · Chris Ferdinandi · commit 0a522c42aa67 · 2014-01-04T18:02:49.000-08:00
Change `offsetHeight` to `scrollHeight` to fix fixed/absolute positioning issues.
diff --git a/smooth-scroll.js b/smooth-scroll.js
@@ -85,7 +85,7 @@
 				// Stop animation when you reach the anchor OR the bottom of the page
 				stopAnimation = function () {
 					var travelled = window.pageYOffset;
-					if ( (travelled >= (endLocation(anchor) - increments)) || ((window.innerHeight + travelled) >= document.body.offsetHeight) ) {
+					if ( (travelled >= (endLocation(anchor) - increments)) || ((window.innerHeight + travelled) >= document.body.scrollHeight) ) {
 						clearInterval(runAnimation);
 						updateURL(url, anchor);
 					}

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@`
`85`	`85`	`// Stop animation when you reach the anchor OR the bottom of the page`
`86`	`86`	`stopAnimation = function () {`
`87`	`87`	`var travelled = window.pageYOffset;`
`88`		`- if ( (travelled >= (endLocation(anchor) - increments)) \|\| ((window.innerHeight + travelled) >= document.body.offsetHeight) ) {`
	`88`	`+ if ( (travelled >= (endLocation(anchor) - increments)) \|\| ((window.innerHeight + travelled) >= document.body.scrollHeight) ) {`
`89`	`89`	`clearInterval(runAnimation);`
`90`	`90`	`updateURL(url, anchor);`
`91`	`91`	`}`