Skip to content

Commit fd06cfa

Browse files
committed
Added RedHat 10 and Debian 13 to platforms to skip for packages tests
Most tests are Debian based. So keep skipping RedHat and skip Debian 13 due to apt-key being deprecated and our public key type being unsupported. Ticket: ENT-13164 ENT-13016 Changelog: none
1 parent bdd2dab commit fd06cfa

File tree

5 files changed

+9
-20
lines changed

5 files changed

+9
-20
lines changed

tests/acceptance/17_packages/01_init/unsafe/timed/001-prepare-repositories.cf

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,13 @@ body common control
1313
"../../../../../../$(sys.local_libdir)/files.cf",
1414
"../../../../../../$(sys.local_libdir)/commands.cf",
1515
"../../../packages-info.cf.sub",
16+
"../../../meta_skip.cf.sub",
1617
};
1718
bundlesequence => { default("$(this.promise_filename)") };
1819
}
1920

2021
bundle agent test
2122
{
22-
meta:
23-
"test_skip_needs_work" string => "!redhat.!debian",
24-
meta => { "redmine5866" };
25-
# RedHat 4 RPM has a bug which corrupts the RPM DB during our tests, so it is untestable.
26-
"test_skip_unsupported" string => "redhat_4|centos_4";
27-
2823
vars:
2924
"bundles" slist => { "repositories",
3025
"signing_keys",

tests/acceptance/17_packages/10_new/unsafe/the_great_package_test.cf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ bundle agent init
3535
# packages where earlier releases did not, so fails many tests.
3636
# RHEL 8 has broken DNF (upgrading a 32bit package also installs a 64bit
3737
# package)
38+
3839
"test_soft_fail" string => "rhel_8|rhel_9",
39-
meta => {"CFE-rhbz", "CFE-4096"};
40+
meta => {"CFE-rhbz", "CFE-4096", "ENT-13499" };
4041

4142
# For setting up the cfengine-selected-python symlink we want to
4243
# target $(sys.bindir) as that will be in the test WORKDIR.

tests/acceptance/17_packages/10_new/unsafe/the_great_package_test_generator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,9 @@ def header(test_count):
121121
# packages where earlier releases did not, so fails many tests.
122122
# RHEL 8 has broken DNF (upgrading a 32bit package also installs a 64bit
123123
# package)
124+
124125
"test_soft_fail" string => "rhel_8|rhel_9",
125-
meta => {"CFE-rhbz", "CFE-4096"};
126+
meta => {"CFE-rhbz", "CFE-4096", "ENT-13499" };
126127
127128
# For setting up the cfengine-selected-python symlink we want to
128129
# target $(sys.bindir) as that will be in the test WORKDIR.

tests/acceptance/17_packages/11_old/unsafe/package-inventory.cf

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,13 @@ body common control
1313
"../../../../../$(sys.local_libdir)/packages.cf",
1414
"../../../../../inventory/any.cf",
1515
"../../packages-info.cf.sub",
16+
"../../meta_skip.cf.sub",
1617
};
1718
bundlesequence => { default($(this.promise_files)) };
1819
}
1920

2021
bundle agent init
2122
{
22-
meta:
23-
# need packages for platforms other than redhat and debian on x86_64 architecture
24-
# see tests/acceptance/17_packages/meta_skip.cf.sub
25-
"test_skip_needs_work" string => "(!redhat.!debian)|(!x86_64)",
26-
meta => { "CFE-3992" };
27-
# RedHat 4 RPM has a bug which corrupts the RPM DB during our tests, so it is untestable.
28-
# And available patches is an Enterprise feature.
29-
"test_skip_unsupported" string => "redhat_4|centos_4|!enterprise";
30-
3123
methods:
3224
"any" usebundle => clear_packages("dummy");
3325
"any" usebundle => install_package("$(p.name[1])", "$(p.version[1])", "$(p.arch)", "dummy");

tests/acceptance/17_packages/meta_skip.cf.sub

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
bundle common 17_packages_meta
22
{
33
meta:
4-
"test_skip_needs_work" string => "(!redhat.!debian)|(!x86_64)",
5-
comment => "Need to create test packages for platforms other than x86 redhat and debian based distributions.",
6-
meta => { "CFE-3993", "CFE-3992"};
4+
"test_skip_needs_work" string => "(!redhat.!debian)|(!x86_64)|(debian_13|redhat_10)",
5+
comment => "Need to create test packages for platforms other than x86 redhat and debian based distributions. Also, debian-13 deprecates apt-key and requires a newer pubkey algorithm.",
6+
meta => { "CFE-3993", "CFE-3992", "ENT-13499" };
77

88
"test_skip_unsupported" string => "redhat_4|centos_4|debian_4|debian_etch",
99
comment => "RedHat 4 RPM has a bug which corrupts the RPM DB during our tests, so it is untestable.",

0 commit comments

Comments
 (0)