ENT-12511: Now cf-net get no longer unlinks original file
#5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `cf-net get <FILENAME>` now writes to `<FILENAME>.cfnew` followed by replacing `<FILENAME>` with `<FILENAME>.cfnew`. Previously it would unlink and re-create the original file. With the new `"filestream"` protocol, we need the original file in order to compute its signature, so that we can save bandwidth using the RSYNC protocol. Furthermore, unlinking the original file, causes a brief moment when it either does not exist or is incomplete. This can be problematic if other processes depend on it. Ticket: ENT-12511 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11534/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11534/ |
The File Stream API now unlinks the destination file (i.e., `<FILENAME>.cfnew`) before opening it with the `O_EXCL` flag. Previously the agent would fail if the destination file already exists. Fortunately, the File Stream API unlinks this file afterwards, both on success and error, causing the agent to recover. Both the `cf-net get <FILENAME>` command and the `copy_from` attribute were affected. Ticket: None Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
1 task
vpodzime
approved these changes
Dec 19, 2024
| } | ||
|
|
||
| if (!success) | ||
| { | ||
| unlink(local_path); | ||
| Log(LOG_LEVEL_VERBOSE, "Removing file '%s'...", dest); |
There was a problem hiding this comment.
These should be INFO, I think. The rule of thumb is that info: message inform the user about changes being made. (applies below as well)
There was a problem hiding this comment.
Not according to @olehermanse (see CFE-4470).
There was a problem hiding this comment.
I have no problem with that. Let's just be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
cf-net get <FILENAME>now writes to<FILENAME>.cfnewfollowed by replacing
<FILENAME>with<FILENAME>.cfnew. Previouslyit would unlink and re-create the original file.
With the new
"filestream"protocol, we need the original file in orderto compute its signature, so that we can save bandwidth using the RSYNC
protocol. Furthermore, unlinking the original file, causes a brief
moment when it either does not exist or is incomplete. This can be
problematic if other processes depend on it.
Ticket: ENT-12511
Changelog: Title
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech