Merge pull request #5991 from larsewi/chroot

larsewi · web-flow · commit be5693d6c2f9 · 2025-12-18T10:32:53.000+01:00
ENT-13551: Fixed potential buffer overflow when computing chroot path
diff --git a/libpromises/changes_chroot.c b/libpromises/changes_chroot.c
@@ -215,7 +215,7 @@ void PrepareChangesChroot(const char *path)
                 continue;
             }
             char entry_path[PATH_MAX];
-            strcpy(entry_path, path);
+            strlcpy(entry_path, path, sizeof(entry_path));
             JoinPaths(entry_path, PATH_MAX, entry->d_name);
             PrepareChangesChroot(entry_path);
         }

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ void PrepareChangesChroot(const char *path)`
`215`	`215`	`continue;`
`216`	`216`	`}`
`217`	`217`	`char entry_path[PATH_MAX];`
`218`		`- strcpy(entry_path, path);`
	`218`	`+ strlcpy(entry_path, path, sizeof(entry_path));`
`219`	`219`	`JoinPaths(entry_path, PATH_MAX, entry->d_name);`
`220`	`220`	`PrepareChangesChroot(entry_path);`
`221`	`221`	`}`