Skip to content

Commit b1c51c1

Browse files
committed
Fixed findlocalusers_unsafe test
Ticket: ENT-13533 Signed-off-by: Victor Moene <victor.moene@northern.tech>
1 parent ff09a71 commit b1c51c1

File tree

2 files changed

+38
-43
lines changed

2 files changed

+38
-43
lines changed

tests/acceptance/01_vars/02_functions/unsafe/findlocalusers_unsafe.cf

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,47 +14,42 @@ bundle agent init
1414
create => "true";
1515

1616
users:
17-
"test_user1"
17+
"testu1"
1818
policy => "present",
1919
home_dir => "/tmp/test_folder1",
2020
description => "TestUser 1",
21-
group_primary => "users",
21+
group_primary => "root", # we need a group which we know for sure the gid
2222
shell => "/bin/sh",
2323
uid => "12345";
2424

25-
"test_user2"
25+
"testu2"
2626
policy => "present",
2727
home_dir => "/tmp/test_folder2",
2828
description => "TestUser 2",
29-
group_primary => "users",
29+
group_primary => "root",
3030
shell => "/bin/sh",
3131
uid => "54321";
3232
vars:
3333
# simple filters
34-
"simple_filter" slist => { "name=root" };
35-
"number_filter" slist => { "uid=0" };
34+
"simple_filter" slist => { "name=testu1" };
35+
"number_filter" slist => { "uid=12345" };
3636

3737
# longer filters
38-
"slist_filter" slist => { "gid=0", "name=root" };
38+
"slist_filter" slist => { "gid=0", "name=testu1" };
3939

4040
# using data
41-
"data_filter" data => '[ "gid=0", "name=root" ]';
41+
"data_filter" data => '[ "gid=0", "name=testu1" ]';
4242

4343
# using regex
44-
"simple_regex" slist => { "name=test_user.*" };
44+
"simple_regex" slist => { "name=testu.*" };
4545
"number_regex" slist => { "uid=1234.*" };
46-
"longer_regex" slist => { "name=test_user.*", "uid=1.*" };
46+
"longer_regex" slist => { "name=testu.*", "uid=1.*" };
4747

4848
# non-existent user
4949
"unknown" slist => { "name=thisuserdoesntexist" };
5050
}
5151
bundle agent test
5252
{
53-
meta:
54-
"test_soft_fail" string => "windows|aix|solaris|hpux|redhat_10",
55-
comment => "RedHat 10 root user is named 'Super User' not 'root'",
56-
meta => { "CFE-2318" };
57-
5853
vars:
5954
"ulist1" data => findlocalusers("@(init.simple_filter)");
6055
"ulist2" data => findlocalusers("init.number_filter");

tests/acceptance/01_vars/02_functions/unsafe/findlocalusers_unsafe.cf.expected.json

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,70 @@
11
{
22
"ulist1": {
3-
"root": {
4-
"dir": "/root",
5-
"gecos": "root",
3+
"testu1": {
4+
"dir": "/tmp/test_folder1",
5+
"gecos": "TestUser 1",
66
"gid": 0,
7-
"shell": "/bin/bash",
8-
"uid": 0
7+
"shell": "/bin/sh",
8+
"uid": 12345
99
}
1010
},
1111
"ulist2": {
12-
"root": {
13-
"dir": "/root",
14-
"gecos": "root",
12+
"testu1": {
13+
"dir": "/tmp/test_folder1",
14+
"gecos": "TestUser 1",
1515
"gid": 0,
16-
"shell": "/bin/bash",
17-
"uid": 0
16+
"shell": "/bin/sh",
17+
"uid": 12345
1818
}
1919
},
2020
"ulist3": {
21-
"root": {
22-
"dir": "/root",
23-
"gecos": "root",
21+
"testu1": {
22+
"dir": "/tmp/test_folder1",
23+
"gecos": "TestUser 1",
2424
"gid": 0,
25-
"shell": "/bin/bash",
26-
"uid": 0
25+
"shell": "/bin/sh",
26+
"uid": 12345
2727
}
2828
},
2929
"ulist4": {
30-
"root": {
31-
"dir": "/root",
32-
"gecos": "root",
30+
"testu1": {
31+
"dir": "/tmp/test_folder1",
32+
"gecos": "TestUser 1",
3333
"gid": 0,
34-
"shell": "/bin/bash",
35-
"uid": 0
34+
"shell": "/bin/sh",
35+
"uid": 12345
3636
}
3737
},
3838
"ulist5": {
39-
"test_user1": {
39+
"testu1": {
4040
"dir": "/tmp/test_folder1",
4141
"gecos": "TestUser 1",
42-
"gid": 100,
42+
"gid": 0,
4343
"shell": "/bin/sh",
4444
"uid": 12345
4545
},
46-
"test_user2": {
46+
"testu2": {
4747
"dir": "/tmp/test_folder2",
4848
"gecos": "TestUser 2",
49-
"gid": 100,
49+
"gid": 0,
5050
"shell": "/bin/sh",
5151
"uid": 54321
5252
}
5353
},
5454
"ulist6": {
55-
"test_user1": {
55+
"testu1": {
5656
"dir": "/tmp/test_folder1",
5757
"gecos": "TestUser 1",
58-
"gid": 100,
58+
"gid": 0,
5959
"shell": "/bin/sh",
6060
"uid": 12345
6161
}
6262
},
6363
"ulist7": {
64-
"test_user1": {
64+
"testu1": {
6565
"dir": "/tmp/test_folder1",
6666
"gecos": "TestUser 1",
67-
"gid": 100,
67+
"gid": 0,
6868
"shell": "/bin/sh",
6969
"uid": 12345
7070
}

0 commit comments

Comments
 (0)