Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeError: Could not find SAML response, check your credentials #60

Closed
JeremJR opened this issue Feb 21, 2018 · 1 comment
Closed

Comments

@JeremJR
Copy link
Contributor

JeremJR commented Feb 21, 2018

While using aws-google-auth from ec2 instances with various ip I've encountered some cases not yet handled :

aws-google-auth --idp-id C01234567 --sp-id 123456789012 -u xxxx.xxxx@example.com -p default
Google Password: 
Traceback (most recent call last):
  File "/usr/bin/aws-google-auth", line 11, in <module>
    load_entry_point('aws-google-auth==0.0.20', 'console_scripts', 'aws-google-auth')()
  File "/usr/lib/python2.7/site-packages/aws_google_auth/__init__.py", line 54, in main
    cli(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/aws_google_auth/__init__.py", line 160, in cli
    saml_xml = google_client.parse_saml()
  File "/usr/lib/python2.7/site-packages/aws_google_auth/google.py", line 153, in parse_saml
    raise RuntimeError('Could not find SAML response, check your credentials')
RuntimeError: Could not find SAML response, check your credentials

For some user I may have to select the challenge https://raw.githubusercontent.com/JeremJR/aws-google-auth/issue/aws_google_auth/tests/selectchallenge_2.html
For another user I may have to enter a phone number to retrieve a token https://raw.githubusercontent.com/JeremJR/aws-google-auth/issue/aws_google_auth/tests/challenge_iap_3.html

I have proposed a PR to handle such cases : #54
But I have no feeback on it yet, maybe due to the coverage test issue.
If so, any advices will be appreciated in order to help increasing the test coverage.

@stevemac007
Copy link
Contributor

Resolved with merge of #54 - please reopen if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants