Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate badge gifting tasks to cron-like jobs #355

Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: migrate badge gifting tasks to cron-like jobs #355

merged 4 commits into from
Jan 26, 2024

Conversation

ruilopesm
Copy link
Member

Closes #340.

@ruilopesm ruilopesm added enhancement Improvements or additions to documentation priority:high High priority labels Nov 12, 2023
@ruilopesm ruilopesm self-assigned this Nov 12, 2023
@ruilopesm
Copy link
Member Author

Requires #356 to be merged first.

ruioliveira02
ruioliveira02 reviewed Nov 12, 2023
View reviewed changes
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. Sometimes you just need something simple that works, and this is a good example of that.

lib/safira/job_scheduler.ex Outdated Show resolved Hide resolved
@ruilopesm ruilopesm marked this pull request as ready for review November 12, 2023 20:00
@diogogmatos
Copy link
Member

feat: migrate badge gifting tasks to cron-like jobs

@ruilopesm ruilopesm mentioned this pull request Dec 2, 2023
Closed
ruioliveira02
ruioliveira02 approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR works. We will have to adjust tasks later on so for now this is perfect 🚀

@ruilopesm ruilopesm merged commit 996fef6 into master Jan 26, 2024
2 checks passed
@ruilopesm ruilopesm deleted the rl/tasks-to-jobs branch January 26, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruioliveira02 ruioliveira02 ruioliveira02 approved these changes

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

@Darguima Darguima Awaiting requested review from Darguima

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

Assignees

@ruilopesm ruilopesm

Labels
enhancement Improvements or additions to documentation priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert badge giving tasks to quantum jobs
3 participants
@ruilopesm @diogogmatos @ruioliveira02