Skip to content

Commit 9f315b0

Browse files
DEV: Update CI workflows (discourse#73)
Co-authored-by: discoursebuild <build@discourse.org>
1 parent 16ddafa commit 9f315b0

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/plugin-linting.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: Set up Node.js
2121
uses: actions/setup-node@v3
2222
with:
23-
node-version: 16
23+
node-version: 18
2424
cache: yarn
2525

2626
- name: Yarn install
@@ -33,25 +33,25 @@ jobs:
3333
bundler-cache: true
3434

3535
- name: ESLint
36-
if: ${{ always() }}
37-
run: yarn eslint --ext .js,.js.es6 --no-error-on-unmatched-pattern {test,assets}/javascripts
36+
if: ${{ !cancelled() }}
37+
run: yarn eslint --ext .js,.js.es6 --no-error-on-unmatched-pattern {test,assets,admin/assets}/javascripts
3838

3939
- name: Prettier
40-
if: ${{ always() }}
40+
if: ${{ !cancelled() }}
4141
shell: bash
4242
run: |
4343
yarn prettier -v
44-
if [ 0 -lt $(find assets -type f \( -name "*.scss" -or -name "*.js" -or -name "*.es6" \) 2> /dev/null | wc -l) ]; then
44+
if [ 0 -lt $(find assets admin/assets -type f \( -name "*.scss" -or -name "*.js" -or -name "*.es6" \) 2> /dev/null | wc -l) ]; then
4545
yarn prettier --list-different "assets/**/*.{scss,js,es6}"
4646
fi
4747
if [ 0 -lt $(find test -type f \( -name "*.js" -or -name "*.es6" \) 2> /dev/null | wc -l) ]; then
4848
yarn prettier --list-different "test/**/*.{js,es6}"
4949
fi
5050
5151
- name: Ember template lint
52-
if: ${{ always() }}
53-
run: yarn ember-template-lint --no-error-on-unmatched-pattern assets/javascripts
52+
if: ${{ !cancelled() }}
53+
run: yarn ember-template-lint --no-error-on-unmatched-pattern assets/javascripts admin/assets/javascripts
5454

5555
- name: Rubocop
56-
if: ${{ always() }}
56+
if: ${{ !cancelled() }}
5757
run: bundle exec rubocop .

0 commit comments

Comments
 (0)