Skip to content
This repository was archived by the owner on May 24, 2024. It is now read-only.

Update dependencies #1611

Merged
merged 8 commits into from
Jun 22, 2018
Merged

Update dependencies #1611

merged 8 commits into from
Jun 22, 2018

Conversation

nfaltermeier
Copy link
Contributor

@nfaltermeier nfaltermeier commented Jun 15, 2018

Summary

terra-date-picker's DateInput never properly implemented react-datepicker's onFocus method which gets passed to custom inputs (which looking at react-datepicker's code might have been intentional) and focus became required for typing in input to work.

Side note: DatePicker grabs a method onInputFocus from its customProps to be called when DateInput gains focus. That method should probably be included as a prop instead of a custom prop.

Additional Details

Part of #1548

Thanks for contributing to Terra.
@cerner/terra

@nfaltermeier nfaltermeier self-assigned this Jun 15, 2018
@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 15, 2018 21:02 Inactive
@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 15, 2018 21:51 Inactive
@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 18, 2018 15:58 Inactive
@nfaltermeier
Copy link
Contributor Author

nfaltermeier commented Jun 18, 2018

The terra-date-picker changes are blocked until Hacker0x01/react-datepicker#1374 is published or something with similar changes (specifically this one). As that could be an indefinite length of time, I am removing that portion of this PR for now.

When you update the time in terra-date-time-picker if the date is invalid it will be cleared because the time update causes react-datepicker to receive new props and if it receives new props while it doesn't have focus it clears it's input field.

@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 20, 2018 13:32 Inactive
@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 21, 2018 13:47 Inactive
@bjankord bjankord temporarily deployed to terra-core-deployed-pr-1611 June 21, 2018 15:12 Inactive
@mjhenkes mjhenkes temporarily deployed to terra-core-deployed-pr-1611 June 21, 2018 21:50 Inactive
@mjhenkes mjhenkes deleted the update-deps branch June 22, 2018 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants