This repository was archived by the owner on May 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The When you update the time in |
bjankord
approved these changes
Jun 19, 2018
saedar
approved these changes
Jun 19, 2018
ryanthemanuel
approved these changes
Jun 21, 2018
StephenEsser
approved these changes
Jun 21, 2018
mjhenkes
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
terra-date-picker
'sDateInput
never properly implementedreact-datepicker
's onFocus method which gets passed to custom inputs (which looking atreact-datepicker
's code might have been intentional) and focus became required for typing in input to work.Side note:
DatePicker
grabs a methodonInputFocus
from itscustomProps
to be called whenDateInput
gains focus. That method should probably be included as a prop instead of a custom prop.Additional Details
Part of #1548
Thanks for contributing to Terra.
@cerner/terra