core/vm: optimize jumpdest analysis (ethereum#23500)

chfast · web-flow · commit 997f1c4f0abc · 2022-06-03T10:40:14.000+02:00
core/vm: optimize PUSH opcode discrimination
diff --git a/core/vm/analysis.go b/core/vm/analysis.go
@@ -76,7 +76,7 @@ func codeBitmapInternal(code, bits bitvec) bitvec {
 	for pc := uint64(0); pc < uint64(len(code)); {
 		op := OpCode(code[pc])
 		pc++
-		if op < PUSH1 || op > PUSH32 {
+		if int8(op) < int8(PUSH1) { // If not PUSH (the int8(op) > int(PUSH32) is always false).
 			continue
 		}
 		numbits := op - PUSH1 + 1

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ func codeBitmapInternal(code, bits bitvec) bitvec {`
`76`	`76`	`for pc := uint64(0); pc < uint64(len(code)); {`
`77`	`77`	`op := OpCode(code[pc])`
`78`	`78`	`pc++`
`79`		`- if op < PUSH1 \|\| op > PUSH32 {`
	`79`	`+ if int8(op) < int8(PUSH1) { // If not PUSH (the int8(op) > int(PUSH32) is always false).`
`80`	`80`	`continue`
`81`	`81`	`}`
`82`	`82`	`numbits := op - PUSH1 + 1`