deploy: Use aggregated ClusterRoles #322
Conversation
|
@kshlm CI failure |
| rbac.ceph.rook.io/aggregate-to-{{ include "ceph-csi-cephfs.nodeplugin.fullname" . }}: "true" | ||
| rules: [] | ||
| --- | ||
| kind: ClusterRole |
|
@kshlm do we need to use |
Not really. I just used the same labels I used in the rook PR. |
|
oh, this is very interesting... You taught me something new about rbac. Thanks. :) I agree, it feels a little weird for rook to be used as a label here. Please update to be something in the ceph namespace. For the helm chart, please break the two different resources into two different files. The helm convention is to have one object per file. say, nodeplugin-clusterrole.yaml and nodeplugin-rules-clusterrole.yaml Overall, looks to be a good change. Thanks. |
|
Oh. and please bump the helm chart versions. |
The kubernetes manifests and Helm templates have been updated to use aggregated ClusterRoles. The same change has been done in Rook as well. Refer rook/rook#2634 and rook/rook#2975 Signed-off-by: Kaushal M <kshlmster@gmail.com>
|
@kfox1111 any final comments from your side ? This looks good to me.. |
deploy: Use aggregated ClusterRoles
Syncing latest changes from upstream devel for ceph-csi
The kubernetes manifests and Helm templates have been updated to use
aggregated ClusterRoles. The same change has been done in Rook as well.
Refer rook/rook#2634 and rook/rook#2975