cephfs: wait for FUSE to exit after unmount #233
Conversation
| @@ -116,10 +124,36 @@ func mountFuse(mountPoint string, cr *credentials, volOptions *volumeOptions, vo | |||
| return err | |||
| } | |||
|
|
|||
| if !bytes.Contains(stderr, []byte("starting fuse")) { | |||
| // Parse the output: | |||
There was a problem hiding this comment.
can you provide a sample output? It helps understand the parsing below. Thanks
There was a problem hiding this comment.
This doesn't output anything unfortunately, but i can sketch it out:
this is the stderr output from ceph-fuse
2019-02-26 21:30:52.556 7f0fb5589c00 -1 auth: unable to find a keyring on /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,: (2) No such file or directory
2019-02-26 21:30:52.568 7f0fb5589c00 -1 init, newargv = 0x1339e30 newargc=9
ceph-fuse[274]: starting ceph client
2019-02-26 21:30:52.568 7f0fb5589c00 -1 auth: unable to find a keyring on /etc/ceph/ceph.client.admin.keyring,/etc/ceph/ceph.keyring,/etc/ceph/keyring,/etc/ceph/keyring.bin,: (2) No such file or directory
ceph-fuse[274]: starting fuse
^ ^ ^
| | |
----------------+ idx points to 's'
| |
-------------+ pidEnd points to ']'
|
---------+ pidStart points to '['
First, we need to search for starting fuse string to make sure the mount is ok. The PID of the daemon is delimited by [ and ]: since we already have the starting position of that string in idx, and we know what the output should look like, we can start searching for the right bracket, starting at the end of the string (as opposed to starting the search at the beginning of the output - this would be less "optimal"). Once we have the position of the right bracket in pidEnd, the same thing is repeated for the left bracket [, whose position is stored in pidStart. The PID should be in between pidStart and pidEnd, i.e. stderr[pidStart+1 : pidEnd]
There was a problem hiding this comment.
would a regex work? https://play.golang.org/p/PdPv1OTs-ZF
There was a problem hiding this comment.
Uff... this is a nice case of over-complicating things, isn't it? :P I'll send a fix
|
PTAL @rootfs |
cephfs: wait for FUSE to exit after unmount
Syncing latest changes from upstream devel for ceph-csi
The symptoms shown in this comment. Once ceph-fuse mounts a volume, it forks the process who's kept running until the volume is unmounted. Since it's a child of the csi plugin, after it exits, it becomes a zombie process and needs to be
Wait()-ed for.This PR reads PID of the FUSE daemon from the initial
ceph-fuseexec and stores it for later in a {volume ID}->{ceph-fuse PID} map. This is then used inunmountVolume()which, once the FUSE volume is unmounted, waits till the FUSE daemon (which is now a zombie) exits and is finally cleaned from kernel's process table.