Fixed DeleteVolume/snapshot metadata idempotency #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f metadata doesn't exist
…d assume the snapshot to be already deleted if metadata doesn't exist
|
PTAL @mickymiek @rootfs @Madhu-1 |
rootfs
approved these changes
Feb 25, 2019
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
Fixed DeleteVolume/snapshot metadata idempotency
nixpanic
pushed a commit
to nixpanic/ceph-csi
that referenced
this pull request
Mar 4, 2024
Syncing latest changes from upstream devel for ceph-csi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
DeleteVolume/DeleteSnapshotRPCs, we perform the deletion of metadata as the final step, meaning all the steps before had to be successful. This PR makes those RPCs assume that if the metadata is missing, the volume/snapshot has been already deleted and will return with success - of course that doesn't protect us against accidental CM deletions causing volume/snapshot leaks, unfortunately.Get()-ing a non-existent cache entry will now result in aCacheEntryNotFounderror. This is used to distinguish between "not found" errors and everything else when querying for entries