Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DeleteVolume/snapshot metadata idempotency #228

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Feb 25, 2019

In DeleteVolume/DeleteSnapshot RPCs, we perform the deletion of metadata as the final step, meaning all the steps before had to be successful. This PR makes those RPCs assume that if the metadata is missing, the volume/snapshot has been already deleted and will return with success - of course that doesn't protect us against accidental CM deletions causing volume/snapshot leaks, unfortunately.

  • Get()-ing a non-existent cache entry will now result in a CacheEntryNotFound error. This is used to distinguish between "not found" errors and everything else when querying for entries
  • if the error is "not found" in Delete operations, we return with success

@gman0
Copy link
Contributor Author

gman0 commented Feb 25, 2019

PTAL @mickymiek @rootfs @Madhu-1

@rootfs rootfs merged commit 5c6bf5f into ceph:csi-v1.0 Feb 25, 2019
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
Fixed DeleteVolume/snapshot metadata idempotency
nixpanic pushed a commit to nixpanic/ceph-csi that referenced this pull request Mar 4, 2024
Syncing latest changes from upstream devel for ceph-csi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants