remove secret and key from logging #220
Conversation
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
| @@ -49,38 +49,39 @@ func closePipeOnError(pipe io.Closer, err error) { | |||
|
|
|||
| func execCommand(program string, args ...string) (stdout, stderr []byte, err error) { | |||
| cmd := exec.Command(program, args...) // nolint: gosec | |||
| klog.V(4).Infof("cephfs: EXEC %s %s", program, util.StripSecretInArgs(args)) | |||
| stripArgs := util.StripSecretInArgs(args) | |||
There was a problem hiding this comment.
eventhough its looks ok, I dont find some value for extra variable here with stripArgs. We could directly use util function in the return call. @gman0 thoughts ?
There was a problem hiding this comment.
@humblec main idea to add a variable to avoid computing time, I didn't want to call util.StripSecretInArgs() multiple times inside same function.
There was a problem hiding this comment.
@Madhu-1 not sure I get it, can you explain how it helps in avoiding computing time ?.
I didn't want to call
util.StripSecretInArgs()multiple times inside same function.
see, either we keep writing util.StripSecretInAgrs() multiple time or we write stripArgs multiple time. I dont see much value here. But I am open for other thoughts.
remove secret and key from logging
Syncing latest changes from upstream devel for ceph-csi
Avoid return of the user keys in case of failure.
@gman0 @rootfs @humblec PTAL