-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move csi-common to ceph-csi #207
Conversation
func (cs *DefaultControllerServer) DeleteSnapshot(ctx context.Context, req *csi.DeleteSnapshotRequest) (*csi.DeleteSnapshotResponse, error) { | ||
return nil, status.Error(codes.Unimplemented, "") | ||
} | ||
|
||
// ListSnapshots list snapshosts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listS snapshots
No Lines 26 to 45 in 8e41a8a
|
@gman0 can this be done in followup PR?
@gman0 can this be done in followup PR? |
6d2fb47
to
ccad30e
Compare
@gman0 removed glog PTAL |
Could you please also remove https://github.com/ceph/ceph-csi/blob/csi-v1.0/pkg/util/log.go ? Not needed anymore. |
@gman0 is that file still present? i think it got deleted |
LGTM |
@@ -32,8 +33,15 @@ var ( | |||
metadataStorage = flag.String("metadatastorage", "", "metadata persistence method [node|k8s_configmap]") | |||
) | |||
|
|||
func init() { | |||
klog.InitFlags(nil) | |||
if err := flag.Set("logtostderr", "true"); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhu-1 did you validate logtostderr
works ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humblec yes tested, am able to see all logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @gman0
@Madhu-1 one quick comment |
lgtm. |
kubernetes/driver/csi-common is no longer maintained. Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
resolved merge conflicts @rootfs PTAL. |
@@ -17,16 +17,15 @@ limitations under the License. | |||
package cephfs | |||
|
|||
import ( | |||
csicommon "github.com/ceph/ceph-csi/pkg/csi-common" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this pkg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.../pkg/csi-common/controllerserver-default.go → pkg/csi-common/controllerserver-default.go
this package is moved under pkg/csi-commom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, github is funny
move csi-common to ceph-csi
Syncing latest changes from devel for ceph-csi
kubernetes/drivers/csi-common
is no longer maintained. moving common utility functions to ceph-csiSigned-off-by: Madhu Rajanna mrajanna@redhat.com