Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to k8s.io/klog from glog. #150

Merged
merged 5 commits into from
Feb 5, 2019
Merged

Migrate to k8s.io/klog from glog. #150

merged 5 commits into from
Feb 5, 2019

Conversation

humblec
Copy link
Collaborator

@humblec humblec commented Jan 28, 2019

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@humblec
Copy link
Collaborator Author

humblec commented Jan 28, 2019

@rootfs ptal :)

@rootfs
Copy link
Member

rootfs commented Jan 28, 2019

@humblec did you add vendor pkgs?

@humblec
Copy link
Collaborator Author

humblec commented Jan 28, 2019

@rootfs will add vendor and rebase.

@humblec
Copy link
Collaborator Author

humblec commented Jan 28, 2019

@rootfs csi-v1.0 branch already has klog , so no need to add it. Rebased the pr to resolve conflict.

@rootfs
Copy link
Member

rootfs commented Jan 28, 2019

@humblec then we don't need to update Gopkg.toml?

@humblec
Copy link
Collaborator Author

humblec commented Jan 28, 2019

@rootfs
Copy link
Member

rootfs commented Jan 28, 2019

if it is used by other vendor pkg, then we don't need it in Gopkg.toml.

btw, does cli option still work with klog, e.g. --v=5?

@rootfs
Copy link
Member

rootfs commented Jan 31, 2019

@humblec can rebase?

@alfredodeza
Copy link

Why is this migrating away from glog? Can we get issues to track changes like this?

@humblec
Copy link
Collaborator Author

humblec commented Feb 4, 2019

@humblec can rebase?

Sure, was on pto last week , so the delay. Doing the same.

@humblec
Copy link
Collaborator Author

humblec commented Feb 4, 2019

Why is this migrating away from glog? Can we get issues to track changes like this?

1.13 kube has done this migration to overcome some of the limitation of glog. So adopting the same here.

@humblec
Copy link
Collaborator Author

humblec commented Feb 4, 2019

@rootfs @gman0 Spurious build failure.

gometalinter: command not found
The command "gometalinter --deadline=10m -j 4  --enable=megacheck --enable=misspell  --vendor ./..." exited with 127.

@rootfs
Copy link
Member

rootfs commented Feb 4, 2019

@humblec can you rebase and trigger the CI again? Want to make sure the gomegalinter issue is fixed. Thanks

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Collaborator Author

humblec commented Feb 5, 2019

@rootfs rebased and its working!

@rootfs rootfs self-assigned this Feb 5, 2019
@rootfs rootfs self-requested a review February 5, 2019 12:08
@mergify mergify bot merged commit f4a1d57 into ceph:csi-v1.0 Feb 5, 2019
@humblec humblec deleted the klog branch February 6, 2019 06:24
nixpanic pushed a commit to nixpanic/ceph-csi that referenced this pull request Feb 28, 2023
sync downstream devel with upstream devel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants