-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to k8s.io/klog from glog. #150
Conversation
@rootfs ptal :) |
@humblec did you add vendor pkgs? |
@rootfs will add vendor and rebase. |
@rootfs csi-v1.0 branch already has |
@humblec then we don't need to update Gopkg.toml? |
@rootfs but I dont see |
if it is used by other vendor pkg, then we don't need it in Gopkg.toml. btw, does cli option still work with klog, e.g. |
@humblec can rebase? |
Why is this migrating away from glog? Can we get issues to track changes like this? |
Sure, was on pto last week , so the delay. Doing the same. |
1.13 kube has done this migration to overcome some of the limitation of glog. So adopting the same here. |
@humblec can you rebase and trigger the CI again? Want to make sure the gomegalinter issue is fixed. Thanks |
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@rootfs rebased and its working! |
sync downstream devel with upstream devel
Signed-off-by: Humble Chirammal hchiramm@redhat.com