Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ceph/ceph-csi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 65016c7a07e1242cb1ac2e2b19265c714810261b
Choose a base ref
...
head repository: ceph/ceph-csi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 25df7d28bbad1fecdfa147bebaf22ef359376efc
Choose a head ref
  • 7 commits
  • 12 files changed
  • 1 contributor

Commits on Jul 2, 2020

  1. rbd: add listsnapshots function 

    added listsnapshots function for an
rbd image to list all the snapshots
created from an rbd images, This will
list the snapshots which are in trash also.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ed63d01 View commit details
    Browse the repository at this point in the history

  2. rbd: add maxsnapshotsonimage flag 

    Added maxsnapshotsonimage flag to flatten
the older rbd images on the chain to avoid
issue in krbd.The limit is in krbd since it
only allocate 1 4KiB page to handle all the
snapshot ids for an image.

The max limit is 510 as per
https://github.com/torvalds/linux/blob/
aaa2faab4ed8e5fe0111e04d6e168c028fe2987f/drivers/block/rbd.c#L98
in cephcsi we arekeeping the default to 450 to reserve 10%
to avoid issues.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    f4cf1a6 View commit details
    Browse the repository at this point in the history

  3. rbd: flatten cloned images to freeup snapshot 

    flatten cloned images to remove the link
with the snapshot as the parent snapshot can
be removed from the trash.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    d10f953 View commit details
    Browse the repository at this point in the history

  4. e2e: set maxsnapshotsonimage during helm install 

    as we need to test the maxsnapshotsonimage we
need to set the limit to minimal value which we
can test in CI as the default limit is 450,which
cannot be tested in CI.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e625b54 View commit details
    Browse the repository at this point in the history

  5. e2e: increase snapshot count to 15 

    Increased the snapshot count to 15, so
that atleast we can verify the maxsnapshots
on images in CI.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    48847e5 View commit details
    Browse the repository at this point in the history

  6. rbd: take lock on parent image during snapshotcreate 

    we need to take lock on parent rbd image when
we are creating a snapshot from it, if the user
tries to delete/resize the rbd image when we are
taking snapshots,we may face issues. if the volume
lock is present on the rbd image, the user cannot
resize the rbd image nor delete the rbd image.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    d7711a6 View commit details
    Browse the repository at this point in the history

  7. e2e: increase e2e test timeout 

    as we are creating more resources as part
of E2E teting, we need to increases the test
timeout as it takes more time to run both cephfs
and rbd tests.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    25df7d2 View commit details
    Browse the repository at this point in the history
Loading