Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to check and test all crates separately #1441

Closed
lemunozm opened this issue Jul 5, 2023 · 0 comments · Fixed by #1444
Closed

Script to check and test all crates separately #1441

lemunozm opened this issue Jul 5, 2023 · 0 comments · Fixed by #1444
Assignees
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue. P4-required Issue should be addressed Q5-hard Can be done by an experienced coder with a good knowledge of the codebase.

Comments

@lemunozm
Copy link
Contributor

lemunozm commented Jul 5, 2023

Description

When testing the entire workspace at once, rust chooses the crates with more features on them. This means that individually our crates can be broken, but because we are compiling all together it just works.

We can avoid this situation and be able to work faster compiling and testing each crate separately with any combination of features as follows:

cargo test -p <my-crate> -F runtime-benchmarks

Also, having them isolated compiling helps to find general compilation issues due to features in the future.

Propose

  • Leave all crates without any compilation issues.
  • Add a job to check automatically that all crates work separately with all feature combinations. This can take time, so I would propose creating a nightly job to do this.
@lemunozm lemunozm added Q5-hard Can be done by an experienced coder with a good knowledge of the codebase. I11-cleaning No mandatory issue that leave the repo more readable/organized P4-required Issue should be addressed labels Jul 5, 2023
@lemunozm lemunozm self-assigned this Jul 5, 2023
@lemunozm lemunozm added I3-annoyance The code behaves as expected, but "expected" is an issue. I11-cleaning No mandatory issue that leave the repo more readable/organized and removed I11-cleaning No mandatory issue that leave the repo more readable/organized labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3-annoyance The code behaves as expected, but "expected" is an issue. P4-required Issue should be addressed Q5-hard Can be done by an experienced coder with a good knowledge of the codebase.
Projects
None yet
1 participant