Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove without_storage_info #1121

Closed
1 task done
mustermeiszer opened this issue Dec 6, 2022 · 0 comments · Fixed by #1122
Closed
1 task done

Remove without_storage_info #1121

mustermeiszer opened this issue Dec 6, 2022 · 0 comments · Fixed by #1122
Assignees
@wischli
Labels
crcl-protocol Circle protocol related. crcl-runtime Circle runtime related. I6-refactoring Code needs refactoring. P7-asap Issue should be addressed in the next days. Q1-easy Can be done by primarily duplicating and adapting code.

Comments

@mustermeiszer
Copy link
Collaborator

Which part of the code is the issue addressing?

  • Refactoring

Description

In order to be able to migrate to frame weights v2 we need to get rid of the #[pallet::without_storage_info] macro that currently is used at all our pallets.

Research/based on

How will this affect the code base

This will enable us to upgrade to frame weights v2 which we need to be able to generate correct PoV blocks and submit them to polkadot.

What are forseen obstacles or hurdles to overcome?

  • Adding MaxEncodedLen to ALL storage items we use
  • Should NOT need a migration
@mustermeiszer mustermeiszer added Q1-easy Can be done by primarily duplicating and adapting code. P7-asap Issue should be addressed in the next days. I6-refactoring Code needs refactoring. crcl-runtime Circle runtime related. crcl-protocol Circle protocol related. labels Dec 6, 2022
@mustermeiszer mustermeiszer mentioned this issue Dec 6, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wischli wischli

Labels
crcl-protocol Circle protocol related. crcl-runtime Circle runtime related. I6-refactoring Code needs refactoring. P7-asap Issue should be addressed in the next days. Q1-easy Can be done by primarily duplicating and adapting code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes without_storage_info macro from pallets centrifuge/centrifuge-chain
2 participants
@wischli @mustermeiszer