Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix statsbeat bugs #1116

Merged
merged 8 commits into from
Apr 15, 2022
Merged

Fix statsbeat bugs #1116

merged 8 commits into from
Apr 15, 2022

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Apr 13, 2022

  1. Do not log when sending statsbeat data
  2. Set is_exporter to True when calling azure_meta_data_service so requests instrumentation will not track requests call as regular telemetry

@lzchen lzchen requested review from a team, aabmass, hectorhdzg and songy23 as code owners April 13, 2022 01:07
hectorhdzg
hectorhdzg approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 85a3284 into census-instrumentation:master Apr 15, 2022
@lzchen lzchen deleted the stats branch April 15, 2022 17:47
@lzchen lzchen added the azure Microsoft Azure label Nov 9, 2022
inirudebwoy pushed a commit to inirudebwoy/opencensus-python that referenced this pull request Jan 11, 2023
@lzchen @inirudebwoy
Fix statsbeat bugs (census-instrumentation#1116)
552910e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@aabmass aabmass Awaiting requested review from aabmass aabmass is a code owner

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
azure Microsoft Azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzchen @hectorhdzg