This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Map http attributes to the stackdriver format#652
Merged
mayurkale22 merged 2 commits intoSep 17, 2019
Conversation
Member
Author
|
/cc @loneparadox Please review |
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=========================================
+ Coverage 95.24% 95.45% +0.2%
=========================================
Files 147 148 +1
Lines 10361 10729 +368
Branches 792 803 +11
=========================================
+ Hits 9868 10241 +373
+ Misses 493 488 -5
Continue to review full report at Codecov.
|
loneparadox
approved these changes
Sep 16, 2019
draffensperger
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #651
These changes have all been tested locally against a real stackdriver instance and been confirmed to be working.