This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Fix duplicate spans issue and clean up#545
Merged
mayurkale22 merged 3 commits intoMay 23, 2019
Merged
Conversation
Member
Author
|
@hekike Please review. |
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 95.34% 95.34% -0.01%
==========================================
Files 147 147
Lines 10600 10553 -47
Branches 735 734 -1
==========================================
- Hits 10107 10062 -45
+ Misses 493 491 -2
Continue to review full report at Codecov.
|
hekike
approved these changes
May 23, 2019
| onEndSpan(span: modelTypes.Span) { | ||
| // Add spans of a trace together when root is ended, skip non root spans. | ||
| // publish function will extract child spans from root. | ||
| if (span.constructor.name !== 'RootSpan') { |
Contributor
There was a problem hiding this comment.
should we have an isRoot on the span btw?
draffensperger
approved these changes
May 23, 2019
Contributor
draffensperger
left a comment
draffensperger
left a comment
There was a problem hiding this comment.
LGTM once comment about how to determine whether a span is a root span is resolved.
hekike
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542