Skip to content

Conversation

@Bashmunta
Copy link

The nil-check for leaves in GetSharesByNamespace was unnecessary because CollectLeavesByNamespace returns an error on any retrieval failure, and the absent-namespace path exits before building shares. This could silently skip elements if retained. Also corrected the function comment to reflect actual behavior: errors short-circuit with no shares, while absent namespace returns no shares and a proof with err == nil.

@github-actions github-actions bot added the external Issues created by non node team members label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Issues created by non node team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant