pass the entire block data when making a block #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
reviewed
May 20, 2022
| state.Validators.GetProposer().Address, | ||
| ) | ||
| return block | ||
| } | ||
|
|
||
| func MakeData(txs []types.Tx, evd []types.Evidence, msgs []types.Message) types.Data { |
There was a problem hiding this comment.
Aren't this duplicate of types.test_util.go ? Or you can't access that one in here ?
There was a problem hiding this comment.
I just didn't want to export it from the types package, as it is only a test util function. You're correct tho, keeping only one copy in types testutil would eliminate the need for one here, and it is an option.
liamsi
approved these changes
May 20, 2022
williambanfield
pushed a commit
to interchainio/celestia-core
that referenced
this pull request
Jul 14, 2022
* pass the entire block data when making a block * linter
evan-forbes
added a commit
that referenced
this pull request
Jul 27, 2022
* pass the entire block data when making a block * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR passes the entire block data instead of the txs, evidence, and messages as distinct objects. This then passes along crucial information such as the square size and the data hash.
blocking celestiaorg/celestia-app#419
Closes #753