remove ISRs for now #723
Merged
remove ISRs for now #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- leave placeholder in proto files - comment out NID
|
Proto-breakage action is expected to fail as we regenerated the proto files (and removed a field). |
adlerjohn
approved these changes
Apr 14, 2022
evan-forbes
approved these changes
Apr 15, 2022
| @@ -88,7 +88,7 @@ message Data { | |||
| // This means that block.AppHash does not include these txs. | |||
| repeated bytes txs = 1; | |||
|
|
|||
| IntermediateStateRoots intermediate_state_roots = 2 [(gogoproto.nullable) = false]; | |||
| // field number 2 is reserved for intermediate state roots | |||
| {types.Tx(tmrand.Bytes(2150)), true}, | ||
| {types.Tx(tmrand.Bytes(2152)), true}, |
There was a problem hiding this comment.
I'm not 100% sure about this, but I think it makes sense after a bit of digging
evan-forbes
added a commit
that referenced
this pull request
Apr 26, 2022
- leave placeholder in proto files - comment out NID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.
Closes: #649