feat: purpose -1 to return all unconfirmed transactions in UnconfirmedTxs RPC #1675
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
rootulp and
evan-forbes
and removed request for
a team
rach-id
commented
Mar 12, 2025
evan-forbes
previously approved these changes
Mar 12, 2025
|
Done |
cmwaters
reviewed
Mar 13, 2025
|
The issue is that core doesn't know about fees. What we could do is run custom queries to get the fees from the app for a set of transactions, but it's the same as just returning the whole thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of creating a new RPC method that returns all the unconfirmed mempool transactions, I used -1 as a special flag to do that. I think it's fine to do so. If it's not, can always define a new endpoint.
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments