Default-backend keys not added properly

[adlerjohn]

Summary of Bug

Adding a key with the default backend doesn't actually add it.

Version

Commit: c8d7cd1

OS: Ubuntu 20.04

Steps to Reproduce

$ celestia-appd keys add foo
$ celestia-appd keys list
[]

[liamsi]

Does this also show an empty list if you explicitly state the backend when doing celestia-appd keys list?

[adlerjohn]

Yes. Additionally, running

$ celestia-appd keys delete foo 
Error: foo.info: key not found

yet foo.info does exist in my OS's keyring.

[liamsi]

By explicitly stating the backend I mean using --keyring-backend os. Does it still show "key not found in that case?

[adlerjohn]

Yes.

Yes.

[rootulp]

OS	c8d7cd1	ff2d92a
macOS Monterey version 12.4	✅	✅
Ubuntu 22.04 x64	✅	✅
Ubuntu 20.04 x64	❌	✅

✅: works as expected
❌: does not work

Nothing in Cosmos SDK docs say that Ubuntu 20.4 isn't supported.

Desired Behavior (output from macOS)

$ celestia-appd keys add foo

- address: celestia1k4k3d2m2k7gckz2z75czgdhnyqsgauzdf9c9z5
  name: foo
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A7bP2v+7zMC1bPzZEYIpOFsShQBdOdGWkYONPs+TTY7l"}'
  type: local

$ celestia-appd keys list
- address: celestia1k4k3d2m2k7gckz2z75czgdhnyqsgauzdf9c9z5
  name: foo
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A7bP2v+7zMC1bPzZEYIpOFsShQBdOdGWkYONPs+TTY7l"}'
  type: local

Actual Behavior (output from c8d7cd1 on Ubuntu 20.04)

root@rootulp-ubuntu-20:~/celestia-app# celestia-appd keys list
migrate err: config.info: key not foundmigrate err: data.info: key not foundError: read /root/.celestia-app/config: is a directory

root@rootulp-ubuntu-20:~/celestia-app# celestia-appd keys add foo
Enter keyring passphrase:
Re-enter keyring passphrase:

- address: celestia10f5556j9swam8tj8d2ugfw95vf9e3jve5z0z9s
  name: foo
  pubkey: '{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"A1aQvKbQiyNV0Y6b3N/bsuGrxGPe8iZFhoLq6ovj7cKW"}'
  type: local

root@rootulp-ubuntu-20:~/celestia-app# celestia-appd keys list
migrate err: config.info: key not foundmigrate err: data.info: key not foundEnter keyring passphrase:
migrate err: keyhash.info: key not foundError: read /root/.celestia-app/config: is a directory

[rootulp]

• c8d7cd1 is based on https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.1.1-sdk-v0.46.0
• ff2d92a is based on https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.2.0-sdk-v0.46.0

It's not clear to me which change fixed this particular issue but these look relevant:

• Error while listing keys using v0.46.x cosmos/cosmos-sdk#12093
• fix: keys migration issue cosmos/cosmos-sdk#12122

even though they were included in https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md#v0452---2022-04-05 so both these commits should have this fix.

@adlerjohn are you able to repro on ff2d92a ? If not, is it safe to resolve this issue?

[adlerjohn]

Amazing investigation