Fixes close method call when imp returns None in loaders #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imp.find_module` returns first argument as `None` if app_path is a module and not a file these changes will call close method only if the file is retuned more information: https://docs.python.org/2/library/imp.html#imp.find_module
|
@auvipy please can you have a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When django-celery tries to find related module from installed apps, the loading fails when
tasksis a module inside one of the installed apps.imp.find_modulereturns first argument asNoneif app_path isa module and not a file
these changes will call close method only if the file is retuned
more information:
https://docs.python.org/2/library/imp.html#imp.find_module