Skip to content

Commit f7540d2

Browse files
committed
BindObjectAsyncHandler should always return a promise
1 parent fc6021e commit f7540d2

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

CefSharp.BrowserSubprocess.Core/BindObjectAsyncHandler.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,9 @@ namespace CefSharp
165165
rootObject->Bind(cachedObjects, context->GetGlobal());
166166

167167
//Objects already bound or ignore cache
168-
retval = CreateResultObject(cachedObjects->Count, "OK", true);
168+
auto promiseResolve = CefV8Value::CreatePromise();
169+
promiseResolve->ResolvePromise(CreateResultObject(cachedObjects->Count, "OK", true));
170+
retval = promiseResolve;
169171

170172
NotifyObjectBound(frame, objectNamesWithBoundStatus);
171173
}
@@ -189,7 +191,9 @@ namespace CefSharp
189191
else
190192
{
191193
//Objects already bound or ignore cache
192-
retval = CreateResultObject(0, "Object(s) already bound", false);
194+
auto promiseResolve = CefV8Value::CreatePromise();
195+
promiseResolve->ResolvePromise(CreateResultObject(0, "Object(s) already bound", false));
196+
retval = promiseResolve;
193197
}
194198
}
195199
else

0 commit comments

Comments
 (0)