Core - Add Cookie.SameSite and Cookie.Priority

Resolves #3254

Author: amaitland

CefSharp.Core/CookieManager.cpp

@@ -53,6 +53,8 @@ namespace CefSharp
 
         c.creation = CefTime(DateTimeUtils::ToCefTime(cookie->Creation));
         c.last_access = CefTime(DateTimeUtils::ToCefTime(cookie->LastAccess));
+        c.same_site = (cef_cookie_same_site_t)cookie->SameSite;
+        c.priority = (cef_cookie_priority_t)cookie->Priority;
 
         return _cookieManager->SetCookie(StringUtils::ToNative(url), c, wrapper);
     }

CefSharp.Core/Internals/TypeConversion.h

@@ -290,6 +290,8 @@ namespace CefSharp
                     cookie->HttpOnly = cefCookie.httponly == 1;
                     cookie->Creation = ConvertCefTimeToDateTime(cefCookie.creation);
                     cookie->LastAccess = ConvertCefTimeToDateTime(cefCookie.last_access);
+                    cookie->SameSite = (CefSharp::Enums::CookieSameSite)cefCookie.same_site;
+                    cookie->Priority = (CefSharp::Enums::CookiePriority)cefCookie.priority;
 
                     if (cefCookie.has_expires)
                     {

CefSharp/CefSharp.csproj

@@ -590,6 +590,8 @@
     <Compile Include="DevTools\WebAuthn\VirtualAuthenticatorOptions.cs" />
     <Compile Include="DevTools\WebAuthn\WebAuthn.cs" />
     <Compile Include="Enums\CompositionUnderlineStyle.cs" />
+    <Compile Include="Enums\CookiePriority.cs" />
+    <Compile Include="Enums\CookieSameSite.cs" />
     <Compile Include="Enums\SchemeOptions.cs" />
     <Compile Include="Handler\RequestContextHandler.cs" />
     <Compile Include="Internals\CefThread.cs" />

CefSharp/Cookie.cs

@@ -4,12 +4,14 @@
 
 using System;
 using System.Diagnostics;
+using CefSharp.Enums;
 
 namespace CefSharp
 {
     /// <summary>
-    /// Class used to Represent a cookie the built in .Net Cookie
-    /// class isn't used as some of it's properties have internal setters
+    /// Class used to Represent a cookie.
+    /// The built in .Net Cookie class isn't used as some of it's properties have
+    /// internal setters
     /// </summary>
     [DebuggerDisplay("Domain = {Domain}, Path = {Path}, Name = {Name}, Secure = {Secure}, HttpOnly = {HttpOnly}," +
                      "Creation = {Creation}, Expires = {Expires}, LastAccess = {LastAccess}", Name = "Cookie")]
@@ -41,7 +43,7 @@ public sealed class Cookie
         /// </summary>
         public bool HttpOnly { get; set; }
         /// <summary>
-        /// Expires or null of no expiry
+        /// Expires or null if no expiry
         /// </summary>
         public DateTime? Expires { get; set; }
         /// <summary>
@@ -52,5 +54,13 @@ public sealed class Cookie
         /// The cookie last access date. This is automatically populated by the system on access. 
         /// </summary>		
         public DateTime LastAccess { get; set; }
+        /// <summary>
+        /// Same site.
+        /// </summary>
+        public CookieSameSite SameSite { get; set; }
+        /// <summary>
+        /// Priority
+        /// </summary>
+        public CookiePriority Priority { get; set; }
     }
 }

CefSharp/Enums/CookiePriority.cs

@@ -0,0 +1,25 @@
+// Copyright © 2020 The CefSharp Authors. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
+
+namespace CefSharp.Enums
+{
+    /// <summary>
+    /// Cookie priority values.
+    /// </summary>
+    public enum CookiePriority
+    {
+        /// <summary>
+        /// Low Priority
+        /// </summary>
+        Low = -1,
+        /// <summary>
+        /// Medium Priority
+        /// </summary>
+        Medium = 0,
+        /// <summary>
+        /// High Priority
+        /// </summary>
+        High = 1,
+    }
+}

CefSharp/Enums/CookieSameSite.cs

@@ -0,0 +1,33 @@
+// Copyright © 2020 The CefSharp Authors. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
+
+namespace CefSharp.Enums
+{
+    /// <summary>
+    /// Cookie same site values.
+    /// </summary>
+    ///<remarks>
+    /// See https://source.chromium.org/chromium/chromium/src/+/master:net/cookies/cookie_constants.h
+    ///</remarks>
+    public enum CookieSameSite
+    {
+        /// <summary>
+        /// Unspecified
+        /// </summary>
+        Unspecified = 0,
+        /// <summary>
+        /// Cookies will be sent in all contexts, i.e sending cross-origin is allowed.
+        /// None used to be the default value, but recent browser versions made Lax the default value to have reasonably robust defense against some classes of cross-site request forgery (CSRF) attacks.
+        /// </summary>
+        NoRestriction,
+        /// <summary>
+        /// Cookies are allowed to be sent with top-level navigations and will be sent along with GET request initiated by third party website. This is the default value in modern browsers.
+        /// </summary>
+        LaxMode,
+        /// <summary>
+        /// Cookies will only be sent in a first-party context and not be sent along with requests initiated by third party websites.
+        /// </summary>
+        StrictMode
+    }
+}