ci: Install clang in CI workflows

* This will make the Makefile of repo simpler to do everyday development

Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>

Author: mahendrapaipuri

.github/workflows/step_tests-e2e.yml

@@ -17,6 +17,9 @@ jobs:
         with:
           go-version: 1.22.x
 
+      - name: Setup clang 18
+        run: ./scripts/install_clang.sh
+
       - name: Run e2e tests for Go packages
         run: make test-e2e
 

.github/workflows/step_tests-unit.yml

@@ -17,6 +17,9 @@ jobs:
         with:
           go-version: 1.22.x
 
+      - name: Setup clang 18
+        run: ./scripts/install_clang.sh
+
       - name: Run checkmetrics and checkrules
         run: make checkmetrics checkrules
 

pkg/collector/testdata/proc.ttar

@@ -9233,6 +9233,24 @@ Node 0, zone    DMA32    759    572    791    475    194     45     12      0
 Node 0, zone   Normal   4381   1093    185   1530    567    102      4      0      0      0      0
 Mode: 644
 # ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+Path: proc/cgroups
+Lines: 14
+#subsys_name    hierarchy       num_cgroups     enabled
+cpuset  5       3       1
+cpu     6       3       1
+cpuacct 6       3       1
+blkio   12      1       1
+memory  7       123     1
+devices 11      51      1
+freezer 2       3       1
+net_cls 4       3       1
+perf_event      3       1       1
+net_prio        4       3       1
+hugetlb 8       1       1
+pids    9       56      1
+rdma    10      1       1 
+Mode: 664
+# ttar - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Path: proc/cmdline
 Lines: 1
 BOOT_IMAGE=/vmlinuz-5.11.0-22-generic root=UUID=456a0345-450d-4f7b-b7c9-43e3241d99ad ro quiet splash vt.handoff=7

scripts/e2e-test.sh

@@ -304,10 +304,10 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v1" \
         --collector.slurm \
         --collector.slurm.gpu-type="nvidia" \
         --collector.slurm.nvidia-smi-path="pkg/collector/testdata/nvidia-smi" \
-        --collector.slurm.force-cgroups-version="v1" \
         --collector.slurm.gpu-job-map-path="pkg/collector/testdata/gpujobmap" \
         --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/freeipmi/ipmi-dcmi" \
         --collector.empty-hostname-label \
@@ -321,11 +321,11 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v1" \
+        --collector.cgroup.active-subsystem="memory" \
         --collector.slurm \
-        --collector.slurm.cgroups-v1-subsystem="memory" \
         --collector.slurm.gpu-type="nvidia" \
         --collector.slurm.nvidia-smi-path="pkg/collector/testdata/nvidia-smi" \
-        --collector.slurm.force-cgroups-version="v1" \
         --collector.slurm.gpu-job-map-path="pkg/collector/testdata/gpujobmap" \
         --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/freeipmi/ipmi-dcmi" \
         --collector.empty-hostname-label \
@@ -339,10 +339,10 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v2" \
         --collector.slurm \
         --collector.slurm.gpu-type="nvidia" \
         --collector.slurm.nvidia-smi-path="pkg/collector/testdata/nvidia-smi" \
-        --collector.slurm.force-cgroups-version="v2" \
         --collector.slurm.gpu-job-map-path="pkg/collector/testdata/gpujobmap" \
         --collector.empty-hostname-label \
         --web.listen-address "127.0.0.1:${port}" \
@@ -355,10 +355,10 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v2" \
         --collector.slurm \
         --collector.slurm.gpu-type="amd" \
         --collector.slurm.rocm-smi-path="pkg/collector/testdata/rocm-smi" \
-        --collector.slurm.force-cgroups-version="v2" \
         --collector.slurm.gpu-job-map-path="pkg/collector/testdata/gpujobmap" \
         --collector.empty-hostname-label \
         --web.listen-address "127.0.0.1:${port}" \
@@ -371,8 +371,8 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v2" \
         --collector.slurm \
-        --collector.slurm.force-cgroups-version="v2" \
         --collector.empty-hostname-label \
         --web.listen-address "127.0.0.1:${port}" \
         --web.disable-exporter-metrics \
@@ -384,10 +384,10 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v2" \
         --collector.slurm \
         --collector.slurm.gpu-type="nvidia" \
         --collector.slurm.nvidia-smi-path="pkg/collector/testdata/nvidia-smi" \
-        --collector.slurm.force-cgroups-version="v2" \
         --collector.ipmi.dcmi.cmd="pkg/collector/testdata/ipmi/ipmiutils/ipmiutil" \
         --collector.empty-hostname-label \
         --web.listen-address "127.0.0.1:${port}" \
@@ -400,10 +400,10 @@ then
         --path.sysfs="pkg/collector/testdata/sys" \
         --path.cgroupfs="pkg/collector/testdata/sys/fs/cgroup" \
         --path.procfs="pkg/collector/testdata/proc" \
+        --collector.cgroups.force-version="v2" \
         --collector.slurm \
         --collector.slurm.gpu-type="amd" \
         --collector.slurm.rocm-smi-path="pkg/collector/testdata/rocm-smi" \
-        --collector.slurm.force-cgroups-version="v2" \
         --collector.slurm.gpu-job-map-path="pkg/collector/testdata/gpujobmap" \
         --collector.slurm.swap.memory.metrics \
         --collector.slurm.psi.metrics \

scripts/install_clang.sh

@@ -1,6 +1,9 @@
 #!/bin/bash
 set -exo pipefail
 
+# This script only works for Ubuntu derivates and it is meant to be
+# used in CI to install clang in golang builder containers.
+
 # Check if clang exists. If it exists, we need to ensure that it
 # is at least of version >= 18
 if [ -x "$(command -v clang)" ]; then