Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzzy matching on unknown method error message #246

Closed
1 of 2 tasks
aaronjeline opened this issue Jul 31, 2023 · 1 comment · Fixed by #1289
Closed
1 of 2 tasks

Fuzzy matching on unknown method error message #246

aaronjeline opened this issue Jul 31, 2023 · 1 comment · Fixed by #1289
Labels
good-first-issue Good for newcomers. A smaller issue that someone new to the Cedar codebase should be able to tackle help-wanted Community help desired. We have not scheduled time to fix this, but think it important. papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request

Comments

@aaronjeline
Copy link
Contributor

Category

Other

Describe the feature you'd like to request

The function ast::Id::to_meth errors if the underlying Id doesn't name a method. It would be useful to fuzzy match the Id against all the possible methods to provide the user with guesses as to what they may have met

Describe alternatives you've considered

Leave error message as is

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@aaronjeline aaronjeline added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. feature-request This issue requets a substantial new feature backlog and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Jul 31, 2023
@andrewmwells-amazon
Copy link
Contributor

It may be worth considering a more general "add suggestions for typos" to error messages. E.g., the ones mentioned in this comment: #222 (comment)

@cdisselkoen cdisselkoen added good-first-issue Good for newcomers. A smaller issue that someone new to the Cedar codebase should be able to tackle help-wanted Community help desired. We have not scheduled time to fix this, but think it important. labels Nov 15, 2023
@sarahcec sarahcec added the papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request label Jan 5, 2024
@john-h-kastner-aws john-h-kastner-aws mentioned this issue Sep 10, 2024
Closed
3 tasks
@john-h-kastner-aws john-h-kastner-aws removed backlog feature-request This issue requets a substantial new feature labels Oct 2, 2024
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers. A smaller issue that someone new to the Cedar codebase should be able to tackle help-wanted Community help desired. We have not scheduled time to fix this, but think it important. papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest method in unknown extension method errors adpaco-aws/cedar
5 participants
@cdisselkoen @aaronjeline @sarahcec @andrewmwells-amazon @john-h-kastner-aws