Skip to content

Commit ffc1c70

Browse files
committed
refactored some stuff
1 parent 4205bb5 commit ffc1c70

8 files changed

+86
-73
lines changed

src/errors.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
class RestoreError extends Error {};
22

33
class CollectionsExist extends RestoreError {
4-
constructor ({ collections } = {}) {
4+
constructor (bag = {}) {
5+
var { collections } = bag;
56
super(
67
`collections [ ${collections.join(',')} ] already exist;` +
78
` set onCollectionExists to "overwrite" to remove this error`

src/restore-buffer.js

Lines changed: 23 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,22 @@ module.exports = (options) => {
1010
return doRestoreBuffer(options);
1111
}
1212

13-
var doRestoreBuffer = async ({
14-
con,
15-
uri,
16-
database,
17-
collection,
13+
var doRestoreBuffer = async (bag) => {
14+
var {
15+
con,
16+
uri,
17+
database,
18+
collection,
1819

19-
from,
20-
//chunked = false,
20+
from,
21+
//chunked = false,
22+
23+
limit,
24+
clean = true,
25+
onCollectionExists = 'throw',
26+
transformDocuments,
27+
} = bag;
2128

22-
limit,
23-
clean = true,
24-
onCollectionExists = 'throw',
25-
transformDocuments,
26-
}) => {
2729
var serverConnection = await maybeConnectServer({ con, uri });
2830

2931
try {
@@ -54,13 +56,15 @@ var doRestoreBuffer = async ({
5456
}
5557
}
5658

57-
var checkOptions = ({
58-
con,
59-
uri,
60-
database,
61-
collection,
62-
from,
63-
}) => {
59+
var checkOptions = (bag) => {
60+
var {
61+
con,
62+
uri,
63+
database,
64+
collection,
65+
from,
66+
} = bag;
67+
6468
if (!con && !uri) {
6569
throw new Error('neither "con" nor "uri" option was given');
6670
}

src/restore-collection.js

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,20 @@ module.exports = (options) => {
1414
return doRestoreCollection(options);
1515
}
1616

17-
var doRestoreCollection = async ({
18-
con,
19-
uri,
20-
database,
21-
collection,
22-
from,
23-
24-
limit,
25-
clean = true,
26-
onCollectionExists = 'throw',
27-
transformDocuments,
28-
}) => {
17+
var doRestoreCollection = async (bag) => {
18+
var {
19+
con,
20+
uri,
21+
database,
22+
collection,
23+
from,
24+
25+
limit,
26+
clean = true,
27+
onCollectionExists = 'throw',
28+
transformDocuments,
29+
} = bag;
30+
2931
// FIXME: this will blow up on large collections
3032
var buffer = fs.readFileSync(from);
3133

@@ -44,14 +46,16 @@ var doRestoreCollection = async ({
4446
};
4547

4648

47-
var checkOptions = ({
48-
con,
49-
uri,
50-
database,
51-
collection,
52-
from,
53-
onCollectionExists,
54-
}) => {
49+
var checkOptions = (bag) => {
50+
var {
51+
con,
52+
uri,
53+
database,
54+
collection,
55+
from,
56+
onCollectionExists,
57+
} = bag;
58+
5559
if (!con && !uri) {
5660
throw new Error('neither "con" nor "uri" option was given');
5761
}

src/restore-database.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,15 @@ var doRestoreDatabase = async (bag) => {
7777
}
7878
}
7979

80-
var checkOptions = ({
81-
con,
82-
uri,
83-
database,
84-
from,
85-
onCollectionExists,
86-
}) => {
80+
var checkOptions = (bag) => {
81+
var {
82+
con,
83+
uri,
84+
database,
85+
from,
86+
onCollectionExists,
87+
} = bag;
88+
8789
if (!con && !uri) {
8890
throw new Error('neither "con" nor "uri" option was given');
8991
}

src/restore-dump.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
2-
var fs = require('fs'),
3-
fspath = require('path'),
4-
restoreDatabase = require('./restore-database');
2+
var fs = require('fs');
3+
var fspath = require('path');
4+
var restoreDatabase = require('./restore-database');
55

66
var { maybeConnectServer } = require('./utils');
77

@@ -61,12 +61,14 @@ var doRestoreDump = async (bag) => {
6161
}
6262
}
6363

64-
var checkOptions = ({
65-
con,
66-
uri,
67-
from,
68-
onCollectionExists
69-
}) => {
64+
var checkOptions = (bag) => {
65+
var {
66+
con,
67+
uri,
68+
from,
69+
onCollectionExists
70+
} = bag;
71+
7072
if (!con && !uri) {
7173
throw new Error('neither "con" nor "uri" option was given');
7274
}

src/utils/internal-restore-buffer.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
'use strict';
22
var BSON = require('bson');
33

4-
var internalRestoreBuffer = async ({
5-
collectionHandle,
4+
var internalRestoreBuffer = async (bag) => {
5+
var {
6+
collectionHandle,
67

7-
buffer,
8-
limit,
9-
// chunked = false
10-
transformDocuments,
11-
}) => {
12-
var index = 0,
13-
documents = [];
8+
buffer,
9+
limit,
10+
// chunked = false
11+
transformDocuments,
12+
} = bag;
13+
14+
var index = 0;
15+
var documents = [];
1416
while (
1517
buffer.length > index
1618
&& (!limit || limit > documents.length)

src/utils/maybe-connect-server.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
'use strict';
22
var MongoClient = require('mongodb').MongoClient;
33

4-
var maybeConnectServer = async ({ con, uri }) => {
4+
var maybeConnectServer = async (bag) => {
5+
var { con, uri } = bag;
6+
57
var serverConnection;
68
if (!con) {
7-
serverConnection = (await MongoClient.connect(
9+
serverConnection = await MongoClient.connect(
810
uri,
911
{ useUnifiedTopology: true }
10-
));
12+
);
1113
}
1214
else {
1315
serverConnection = con;

src/utils/try-create-collection.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
var verifyCollectionsDontExist = require('./verify-collections-dont-exist');
33

44
var tryCreateCollection = async (bag) => {
5-
var {
6-
dbHandle,
7-
collection,
8-
onCollectionExists
9-
} = bag;
5+
var { dbHandle, collection, onCollectionExists } = bag;
106

117
var doesntExist = await verifyCollectionsDontExist({
128
dbHandle,

0 commit comments

Comments
 (0)